net/cert/cert_verify_result.h - Issue 27624002: Add a histogram for measuring the number of times we fall back to common name matching, when a cert…

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: net/cert/cert_verify_result.h

Issue 27624002: Add a histogram for measuring the number of times we fall back to common name matching, when a cert… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: whitespace Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« net/cert/cert_verify_proc_nss.cc ('K') | « net/cert/cert_verify_proc_win.cc ('k') | net/cert/cert_verify_result.cc » ('j') | net/cert/x509_certificate.h » ('J')

OLD	NEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef NET_CERT_CERT_VERIFY_RESULT_H_	5 #ifndef NET_CERT_CERT_VERIFY_RESULT_H_

6 #define NET_CERT_CERT_VERIFY_RESULT_H_	6 #define NET_CERT_CERT_VERIFY_RESULT_H_

7	7

8 #include <vector>	8 #include <vector>

9	9

10 #include "base/memory/ref_counted.h"	10 #include "base/memory/ref_counted.h"

(...skipping 44 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
55	55

56 // is_issued_by_known_root is true if we recognise the root CA as a standard	56 // is_issued_by_known_root is true if we recognise the root CA as a standard

57 // root. If it isn't then it's probably the case that this certificate was	57 // root. If it isn't then it's probably the case that this certificate was

58 // generated by a MITM proxy whose root has been installed locally. This is	58 // generated by a MITM proxy whose root has been installed locally. This is

59 // meaningless if the certificate was not trusted.	59 // meaningless if the certificate was not trusted.

60 bool is_issued_by_known_root;	60 bool is_issued_by_known_root;

61	61

62 // is_issued_by_additional_trust_anchor is true if the root CA used for this	62 // is_issued_by_additional_trust_anchor is true if the root CA used for this

63 // verification came from the list of additional trust anchors.	63 // verification came from the list of additional trust anchors.

64 bool is_issued_by_additional_trust_anchor;	64 bool is_issued_by_additional_trust_anchor;

	65

	66 // True if a fallback to the common name was used when matching the host

	67 // name, rather than using the subjectAlternativeName.
	wtc 2013/10/23 22:39:26 Nit: consider using "subjectAltName", the form use Nit: consider using "subjectAltName", the form used in RFC 5280.
	68 bool common_name_fallback_used;

65 };	69 };

66	70

67 } // namespace net	71 } // namespace net

68	72

69 #endif // NET_CERT_CERT_VERIFY_RESULT_H_	73 #endif // NET_CERT_CERT_VERIFY_RESULT_H_

OLD	NEW