chrome/browser/extensions/api/automation_internal/automation_internal_api.cc - Issue 2762373002: Fix computation of Automation API location offsets in WebViews.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/automation_internal/automation_internal_api.cc

Issue 2762373002: Fix computation of Automation API location offsets in WebViews. (Closed)

Patch Set: Only run new test on chromeos because of required perms Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/automation/automation_apitest.cc ('k') | chrome/common/extensions/chrome_extension_messages.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/automation_internal/automation_internal_api.cc

diff --git a/chrome/browser/extensions/api/automation_internal/automation_internal_api.cc b/chrome/browser/extensions/api/automation_internal/automation_internal_api.cc

index ced7dde6d0326915853acbc3a2c287df16e7bd26..916d4407f866693ab9a494cfae2ec2a73ae01343 100644

--- a/chrome/browser/extensions/api/automation_internal/automation_internal_api.cc

+++ b/chrome/browser/extensions/api/automation_internal/automation_internal_api.cc

@@ -176,8 +176,6 @@ class AutomationWebContentsObserver

params.id = event.id;

params.event_type = event.event_type;

params.update = event.update;

- params.location_offset =

- web_contents()->GetContainerBounds().OffsetFromOrigin();

params.event_from = event.event_from;

AutomationEventRouter* router = AutomationEventRouter::GetInstance();