 Chromium Code Reviews
 Chromium Code Reviews Issue 2762333003:
  Pref service: add a factory to create the client lib  (Closed)
    
  
    Issue 2762333003:
  Pref service: add a factory to create the client lib  (Closed) 
  | Index: services/preferences/BUILD.gn | 
| diff --git a/services/preferences/BUILD.gn b/services/preferences/BUILD.gn | 
| index 524b6bd8a28ed2f6b959f0688e8bc833f017b029..2ee25531c62884185aa90fc6c706221ccab4d462 100644 | 
| --- a/services/preferences/BUILD.gn | 
| +++ b/services/preferences/BUILD.gn | 
| @@ -2,16 +2,10 @@ | 
| # Use of this source code is governed by a BSD-style license that can be | 
| # found in the LICENSE file. | 
| +import("//services/catalog/public/tools/catalog.gni") | 
| import("//services/service_manager/public/service_manifest.gni") | 
| import("//testing/test.gni") | 
| -group("tests") { | 
| - testonly = true | 
| - deps = [ | 
| - ":preferences_unittests", | 
| - ] | 
| -} | 
| - | 
| service_manifest("manifest") { | 
| name = "preferences2" | 
| source = "manifest.json" | 
| @@ -32,21 +26,36 @@ source_set("preferences") { | 
| ] | 
| } | 
| -test("preferences_unittests") { | 
| +source_set("tests") { | 
| + testonly = true | 
| deps = [ | 
| ":preferences", | 
| "//base", | 
| "//base/test:test_support", | 
| "//components/prefs:test_support", | 
| - "//mojo/edk/test:run_all_unittests", | 
| "//mojo/public/cpp/bindings:bindings", | 
| "//services/preferences/public/cpp", | 
| "//services/preferences/public/cpp/tests", | 
| "//services/preferences/public/interfaces", | 
| + "//services/service_manager/public/cpp", | 
| "//testing/gmock", | 
| "//testing/gtest", | 
| ] | 
| sources = [ | 
| "persistent_pref_store_impl_unittest.cc", | 
| ] | 
| + if (!is_ios) { | 
| + sources += [ "pref_service_factory_unittest.cc" ] | 
| + deps += [ "//services/service_manager/public/cpp:service_test_support" ] | 
| + } | 
| +} | 
| + | 
| +service_manifest("unittest_manifest") { | 
| + name = "prefs_unittests" | 
| + source = "unittest_manifest.json" | 
| + packaged_services = [ ":manifest" ] | 
| +} | 
| + | 
| +catalog("tests_catalog") { | 
| 
Sam McNally
2017/03/22 04:34:03
testonly = true
 
tibell
2017/03/22 05:32:04
Done.
 | 
| + embedded_services = [ ":unittest_manifest" ] | 
| } |