Side by Side Diff
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Keyboard Shortcuts
File
u
:
up to issue
j
/
k
:
jump to file after / before current file
J
/
K
:
jump to next file with a comment after / before current file
Side-by-side diff
i
:
toggle intra-line diffs
e
:
expand all comments
c
:
collapse all comments
s
:
toggle showing all comments
n
/
p
:
next / previous diff chunk or comment
N
/
P
:
next / previous comment
<Up>
/
<Down>
:
next / previous line
Issue
u
:
up to list of issues
j
/
k
:
jump to patch after / before current patch
o
/
<Enter>
:
open current patch in side-by-side view
i
:
open current patch in unified diff view
Issue List
j
/
k
:
jump to issue after / before current issue
o
/
<Enter>
:
open current issue
Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr)
|
Please choose your nickname with
Settings
|
Help
|
Chromium Project
|
Gerrit Changes
|
Sign out
(1)
Issues
Search
My Issues
|
Starred
Open
|
Closed
|
All
Side by Side Diff: services/preferences/unittest_manifest.json
Issue
2762333003
:
Pref service: add a factory to create the client lib (Closed)
Patch Set: Address more review comments from sammc@
Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Context:
3 lines
10 lines
25 lines
50 lines
75 lines
100 lines
Whole file
Column Width:
Tab Spaces:
Jump to:
BUILD.gn
services/BUILD.gn
services/preferences/BUILD.gn
services/preferences/manifest.json
services/preferences/pref_service_factory_unittest.cc
services/preferences/public/cpp/BUILD.gn
services/preferences/public/cpp/pref_service_factory.h
services/preferences/public/cpp/pref_service_factory.cc
services/preferences/public/cpp/pref_store_manager_impl.h
services/preferences/public/cpp/pref_store_manager_impl.cc
services/preferences/unittest_manifest.json
services/service_manager/public/cpp/lib/service_test.cc
services/service_manager/public/tools/test/service_test.gni
View unified diff
|
Download patch
« services/preferences/public/cpp/pref_service_factory.h
('K') |
« services/preferences/public/cpp/pref_store_manager_impl.cc
('k') |
services/service_manager/public/cpp/lib/service_test.cc »
('j') |
no next file with comments »
Toggle Intra-line Diffs
('i') |
Expand Comments
('e') |
Collapse Comments
('c') |
Show Comments
Hide Comments
('s')
OLD
NEW
(Empty)
1
{
2
"name": "prefs_unittests",
3
"display_name": "Prefs Unittests",
4
"interface_provider_specs": {
5
"service_manager:connector": {
6
"provides": {
7
"service_manager:service_factory": [
8
"service_manager::mojom::ServiceFactory"
9
]
10
},
11
"requires": {
12
"preferences2": [ "pref_client", "pref_control" ]
13
}
14
}
15
}
16
}
OLD
NEW
« services/preferences/public/cpp/pref_service_factory.h
('K') |
« services/preferences/public/cpp/pref_store_manager_impl.cc
('k') |
services/service_manager/public/cpp/lib/service_test.cc »
('j') |
no next file with comments »
Issue 2762333003: Pref service: add a factory to create the client lib (Closed)
Created 3 years, 9 months ago by tibell
Modified 3 years, 9 months ago
Reviewers: Ken Rockot(use gerrit already), Sam McNally, scottmg
Base URL:
Comments: 25
This is Rietveld
408576698
Chromium Code Reviews
Issue 2762333003:
Pref service: add a factory to create the client lib (Closed)
