Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Side by Side Diff: BUILD.gn

Issue 2762333003: Pref service: add a factory to create the client lib (Closed)
Patch Set: Address more review comments from sammc@ Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 # This is the root build file for GN. GN will start processing by loading this 5 # This is the root build file for GN. GN will start processing by loading this
6 # file, and recursively load all dependencies until all dependencies are either 6 # file, and recursively load all dependencies until all dependencies are either
7 # resolved or known not to exist (which will cause the build to fail). So if 7 # resolved or known not to exist (which will cause the build to fail). So if
8 # you add a new build file, there must be some path of dependencies from this 8 # you add a new build file, there must be some path of dependencies from this
9 # file to your new one or GN won't know about it. 9 # file to your new one or GN won't know about it.
10 10
(...skipping 585 matching lines...) Expand 10 before | Expand all | Expand 10 after
596 if (!is_android && !is_ios && !is_chromeos) { 596 if (!is_android && !is_ios && !is_chromeos) {
597 deps += [ "//components/proximity_auth:proximity_auth_unittests" ] 597 deps += [ "//components/proximity_auth:proximity_auth_unittests" ]
598 } 598 }
599 599
600 if (is_win || is_linux) { 600 if (is_win || is_linux) {
601 deps += [ 601 deps += [
602 "//mash:all", 602 "//mash:all",
603 "//media/mojo/services:media_service_unittests", 603 "//media/mojo/services:media_service_unittests",
604 "//mojo", 604 "//mojo",
605 "//services/navigation", 605 "//services/navigation",
606 "//services/preferences:tests",
607 "//services/ui/demo", 606 "//services/ui/demo",
608 "//services/ui/demo:mus_demo_unittests", 607 "//services/ui/demo:mus_demo_unittests",
609 "//services/ui/public/interfaces:ui_struct_traits_unittests", 608 "//services/ui/public/interfaces:ui_struct_traits_unittests",
610 "//services/ui/ws:tests", 609 "//services/ui/ws:tests",
611 "//ui/views/mus:views_mus_interactive_ui_tests", 610 "//ui/views/mus:views_mus_interactive_ui_tests",
612 "//ui/views/mus:views_mus_unittests", 611 "//ui/views/mus:views_mus_unittests",
613 ] 612 ]
614 613
615 # crbug.com/676055: media_service_unittests fails to link under Windows 614 # crbug.com/676055: media_service_unittests fails to link under Windows
616 # component builds, due to duplicate symbol definitions. 615 # component builds, due to duplicate symbol definitions.
(...skipping 459 matching lines...) Expand 10 before | Expand all | Expand 10 after
1076 assert(target_name != "") # Mark as used. 1075 assert(target_name != "") # Mark as used.
1077 sources = invoker.actual_sources 1076 sources = invoker.actual_sources
1078 assert( 1077 assert(
1079 sources == invoker.actual_sources, 1078 sources == invoker.actual_sources,
1080 "Do not use a platform name in your output directory (found \"$root_build_ dir\"). http://crbug.com/548283") 1079 "Do not use a platform name in your output directory (found \"$root_build_ dir\"). http://crbug.com/548283")
1081 } 1080 }
1082 1081
1083 assert_valid_out_dir("_unused") { 1082 assert_valid_out_dir("_unused") {
1084 actual_sources = [ "$root_build_dir/foo" ] 1083 actual_sources = [ "$root_build_dir/foo" ]
1085 } 1084 }
OLDNEW
« no previous file with comments | « no previous file | services/BUILD.gn » ('j') | services/preferences/public/cpp/pref_service_factory.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698