Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(288)

Side by Side Diff: runtime/vm/dart.cc

Issue 2762313003: Dwarf tools interpret line number table pc's as start boundries instead of end boundries. (Closed)
Patch Set: test Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/dart.h" 5 #include "vm/dart.h"
6 6
7 #include "vm/become.h" 7 #include "vm/become.h"
8 #include "vm/clustered_snapshot.h" 8 #include "vm/clustered_snapshot.h"
9 #include "vm/code_observers.h" 9 #include "vm/code_observers.h"
10 #include "vm/cpu.h" 10 #include "vm/cpu.h"
(...skipping 687 matching lines...) Expand 10 before | Expand all | Expand 10 after
698 #else 698 #else
699 buffer.AddString(" x64-sysv"); 699 buffer.AddString(" x64-sysv");
700 #endif 700 #endif
701 #elif defined(TARGET_ARCH_DBC) 701 #elif defined(TARGET_ARCH_DBC)
702 buffer.AddString(" dbc"); 702 buffer.AddString(" dbc");
703 #elif defined(TARGET_ARCH_DBC64) 703 #elif defined(TARGET_ARCH_DBC64)
704 buffer.AddString(" dbc64"); 704 buffer.AddString(" dbc64");
705 #endif 705 #endif
706 } 706 }
707 707
708 if (FLAG_dwarf_stack_traces) { 708 if (FLAG_precompiled_mode && FLAG_dwarf_stack_traces) {
709 buffer.AddString(" dwarf-stack-traces"); 709 buffer.AddString(" dwarf-stack-traces");
710 } 710 }
711 711
712 return buffer.Steal(); 712 return buffer.Steal();
713 } 713 }
714 714
715 715
716 void Dart::RunShutdownCallback() { 716 void Dart::RunShutdownCallback() {
717 Isolate* isolate = Isolate::Current(); 717 Isolate* isolate = Isolate::Current();
718 void* callback_data = isolate->init_callback_data(); 718 void* callback_data = isolate->init_callback_data();
(...skipping 47 matching lines...) Expand 10 before | Expand all | Expand 10 after
766 return predefined_handles_->handles_.IsValidScopedHandle(address); 766 return predefined_handles_->handles_.IsValidScopedHandle(address);
767 } 767 }
768 768
769 769
770 bool Dart::IsReadOnlyApiHandle(Dart_Handle handle) { 770 bool Dart::IsReadOnlyApiHandle(Dart_Handle handle) {
771 ASSERT(predefined_handles_ != NULL); 771 ASSERT(predefined_handles_ != NULL);
772 return predefined_handles_->api_handles_.IsValidHandle(handle); 772 return predefined_handles_->api_handles_.IsValidHandle(handle);
773 } 773 }
774 774
775 } // namespace dart 775 } // namespace dart
OLDNEW
« no previous file with comments | « no previous file | runtime/vm/dart_api_impl.cc » ('j') | tests/standalone/dwarf_stack_trace_test.dart » ('J')

Powered by Google App Engine
This is Rietveld 408576698