Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(198)

Unified Diff: chrome/browser/ui/autofill/popup_controller_common.cc

Issue 2762233004: Fix autofill popup controller key press callback registration (Closed)
Patch Set: Fix typo Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/autofill/popup_controller_common.cc
diff --git a/chrome/browser/ui/autofill/popup_controller_common.cc b/chrome/browser/ui/autofill/popup_controller_common.cc
index 2c97b8b7c222c6fb58f61eebf43f28da21da1208..85827b66d7a09e7a9b3adafb8c268c8984448275 100644
--- a/chrome/browser/ui/autofill/popup_controller_common.cc
+++ b/chrome/browser/ui/autofill/popup_controller_common.cc
@@ -4,46 +4,16 @@
#include "chrome/browser/ui/autofill/popup_controller_common.h"
-#include "content/public/browser/render_view_host.h"
-#include "content/public/browser/web_contents.h"
-
namespace autofill {
PopupControllerCommon::PopupControllerCommon(
const gfx::RectF& element_bounds,
base::i18n::TextDirection text_direction,
- const gfx::NativeView container_view,
- content::WebContents* web_contents)
- : element_bounds_(element_bounds),
- text_direction_(text_direction),
- container_view_(container_view),
- web_contents_(web_contents),
- key_press_event_target_(NULL) {
-}
-PopupControllerCommon::~PopupControllerCommon() {}
-
-void PopupControllerCommon::SetKeyPressCallback(
- content::RenderWidgetHost::KeyPressEventCallback callback) {
- DCHECK(key_press_event_callback_.is_null());
- key_press_event_callback_ = callback;
-}
+ gfx::NativeView container_view)
+ : element_bounds(element_bounds),
+ text_direction(text_direction),
+ container_view(container_view) {}
-void PopupControllerCommon::RegisterKeyPressCallback() {
- if (web_contents_ && !key_press_event_target_) {
- key_press_event_target_ = web_contents_->GetRenderViewHost();
- key_press_event_target_->GetWidget()->AddKeyPressEventCallback(
- key_press_event_callback_);
- }
-}
-
-void PopupControllerCommon::RemoveKeyPressCallback() {
- if (web_contents_ && (!web_contents_->IsBeingDestroyed()) &&
- key_press_event_target_ == web_contents_->GetRenderViewHost()) {
- web_contents_->GetRenderViewHost()
- ->GetWidget()
- ->RemoveKeyPressEventCallback(key_press_event_callback_);
- }
- key_press_event_target_ = NULL;
-}
+PopupControllerCommon::~PopupControllerCommon() {}
} // namespace autofill
« no previous file with comments | « chrome/browser/ui/autofill/popup_controller_common.h ('k') | chrome/test/data/autofill/cross_origin_iframe.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698