chrome/browser/ui/autofill/password_generation_popup_view_browsertest.cc - Issue 2762233004: Fix autofill popup controller key press callback registration

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/autofill/password_generation_popup_view_browsertest.cc

Issue 2762233004: Fix autofill popup controller key press callback registration (Closed)

Patch Set: Fix typo Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/autofill/password_generation_popup_controller_impl.cc ('k') | chrome/browser/ui/autofill/popup_controller_common.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/autofill/password_generation_popup_view_browsertest.cc

diff --git a/chrome/browser/ui/autofill/password_generation_popup_view_browsertest.cc b/chrome/browser/ui/autofill/password_generation_popup_view_browsertest.cc

index a5929ffd4c3bb241fa188cbf14bf6729e65e1d81..3e23018a38ceb553be6dfc862d79c7fce6c40e52 100644

--- a/chrome/browser/ui/autofill/password_generation_popup_view_browsertest.cc

+++ b/chrome/browser/ui/autofill/password_generation_popup_view_browsertest.cc

@@ -12,6 +12,8 @@

#include "chrome/browser/ui/browser_window.h"

#include "chrome/browser/ui/tabs/tab_strip_model.h"

#include "chrome/test/base/in_process_browser_test.h"

+#include "components/password_manager/content/browser/content_password_manager_driver.h"

+#include "components/password_manager/content/browser/content_password_manager_driver_factory.h"

#include "testing/gtest/include/gtest/gtest.h"

#include "ui/events/event_utils.h"

@@ -27,7 +29,9 @@ class TestPasswordGenerationPopupController :

PasswordForm(),

10,

nullptr /* PasswordManager*/,

- nullptr /* PasswordManagerDriver*/,

+ password_manager::ContentPasswordManagerDriverFactory::

+ FromWebContents(web_contents)

+ ->GetDriverForFrame(web_contents->GetMainFrame()),

nullptr /* PasswordGenerationPopupObserver*/,

web_contents,

native_view) {}