components/password_manager/core/browser/password_autofill_manager.h - Issue 2762233004: Fix autofill popup controller key press callback registration

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/password_manager/core/browser/password_autofill_manager.h

Issue 2762233004: Fix autofill popup controller key press callback registration (Closed)

Patch Set: Fixed browsertests Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/autofill/content/browser/key_press_handler_manager.cc ('K') | « components/password_manager/content/browser/content_password_manager_driver.cc ('k') | components/password_manager/core/browser/password_autofill_manager.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/password_manager/core/browser/password_autofill_manager.h

diff --git a/components/password_manager/core/browser/password_autofill_manager.h b/components/password_manager/core/browser/password_autofill_manager.h

index 56a5b5c62bac958dfa4b9b903c6aaa05026243d0..737bc926e3a8ec19f373a513ca526edb5e422609 100644

--- a/components/password_manager/core/browser/password_autofill_manager.h

+++ b/components/password_manager/core/browser/password_autofill_manager.h

@@ -43,6 +43,7 @@ class PasswordAutofillManager : public autofill::AutofillPopupDelegate {

bool RemoveSuggestion(const base::string16& value, int identifier) override;

void ClearPreviewedForm() override;

bool IsCreditCardPopup() override;

+ autofill::AutofillDriver* GetAutofillDriver() override;

// Invoked when a password mapping is added.

void OnAddPasswordFormMapping(