Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Unified Diff: third_party/sqlite/src/src/util.c

Issue 2762233003: [sql] Disable a clang intrinsic in SQLite 3.17.0. (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/sqlite/patches/0010-build-Undefined-symbol-in-intrinsic-on-clang.patch ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/sqlite/src/src/util.c
diff --git a/third_party/sqlite/src/src/util.c b/third_party/sqlite/src/src/util.c
index 0a76ddec683de97bec6b9fa6c1fc03057549db87..445aba9b48e4ae3080f8326e42eab779df3f8dac 100644
--- a/third_party/sqlite/src/src/util.c
+++ b/third_party/sqlite/src/src/util.c
@@ -1310,13 +1310,12 @@ int sqlite3SubInt64(i64 *pA, i64 iB){
#endif
}
int sqlite3MulInt64(i64 *pA, i64 iB){
-/* TODO(shess): Chromium Android clang generates a link error:
+/* TODO(shess): Removing clang support because on many platforms it generates a
+** link error for this intrinsic:
** undefined reference to '__mulodi4'
-** UPDATE(shess): Also, apparently, 32-bit Linux clang.
+** http://crbug.com/701524
*/
-#if GCC_VERSION>=5004000 || \
- (CLANG_VERSION>=4000000 && !defined(__ANDROID__) && \
- (!defined(__linux__) || !defined(__i386__)))
+#if GCC_VERSION>=5004000
return __builtin_mul_overflow(*pA, iB, pA);
#else
i64 iA = *pA;
« no previous file with comments | « third_party/sqlite/patches/0010-build-Undefined-symbol-in-intrinsic-on-clang.patch ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698