Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(839)

Unified Diff: runtime/vm/kernel_to_il.h

Issue 2762213002: Use canonical names for some name-based lookup. (Closed)
Patch Set: Do not use the import URI to name libraries Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/kernel_reader.cc ('k') | runtime/vm/kernel_to_il.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/kernel_to_il.h
diff --git a/runtime/vm/kernel_to_il.h b/runtime/vm/kernel_to_il.h
index 45003704ab6427b22d7f467688544a930916f23c..e6033eb45cf6d2beee81da5201cb68ce1b3fba47 100644
--- a/runtime/vm/kernel_to_il.h
+++ b/runtime/vm/kernel_to_il.h
@@ -253,7 +253,7 @@ class TranslationHelper {
const dart::String& DartSymbol(const char* content) const;
dart::String& DartSymbol(String* content) const;
- const dart::String& DartClassName(Class* kernel_klass);
+ const dart::String& DartClassName(CanonicalName* kernel_klass);
const dart::String& DartConstructorName(Constructor* node);
const dart::String& DartProcedureName(Procedure* procedure);
@@ -269,8 +269,8 @@ class TranslationHelper {
// A subclass overrides these when reading in the Kernel program in order to
// support recursive type expressions (e.g. for "implements X" ...
// annotations).
- virtual RawLibrary* LookupLibraryByKernelLibrary(Library* library);
- virtual RawClass* LookupClassByKernelClass(Class* klass);
+ virtual RawLibrary* LookupLibraryByKernelLibrary(CanonicalName* library);
+ virtual RawClass* LookupClassByKernelClass(CanonicalName* klass);
RawField* LookupFieldByKernelField(Field* field);
RawFunction* LookupStaticMethodByKernelProcedure(Procedure* procedure);
@@ -287,7 +287,7 @@ class TranslationHelper {
private:
// This will mangle [kernel_name] (if necessary) and make the result a symbol.
// The result will be avilable in [name_to_modify] and it is also returned.
- dart::String& ManglePrivateName(Library* kernel_library,
+ dart::String& ManglePrivateName(CanonicalName* kernel_library,
dart::String* name_to_modify,
bool symbolize = true);
« no previous file with comments | « runtime/vm/kernel_reader.cc ('k') | runtime/vm/kernel_to_il.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698