Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Unified Diff: include/v8.h

Issue 2762163002: Revert of [wasm] Transferrable modules (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/api.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: include/v8.h
diff --git a/include/v8.h b/include/v8.h
index aeba61f7beddbe47552e7252a9119c7cf5c3f756..fe38d236a481af4e003809437cf3ee1689eff72a 100644
--- a/include/v8.h
+++ b/include/v8.h
@@ -108,7 +108,6 @@
class Uint32;
class Utils;
class Value;
-class WasmCompiledModule;
template <class T> class Local;
template <class T>
class MaybeLocal;
@@ -1711,8 +1710,6 @@
virtual Maybe<uint32_t> GetSharedArrayBufferId(
Isolate* isolate, Local<SharedArrayBuffer> shared_array_buffer);
- virtual Maybe<uint32_t> GetWasmModuleTransferId(
- Isolate* isolate, Local<WasmCompiledModule> module);
/*
* Allocates memory for the buffer of at least the size provided. The actual
* size (which may be greater or equal) is written to |actual_size|. If no
@@ -1823,13 +1820,6 @@
* MaybeLocal<Object>() returned.
*/
virtual MaybeLocal<Object> ReadHostObject(Isolate* isolate);
-
- /*
- * Get a WasmCompiledModule given a transfer_id previously provided
- * by ValueSerializer::GetWasmModuleTransferId
- */
- virtual MaybeLocal<WasmCompiledModule> GetWasmModuleFromId(
- Isolate* isolate, uint32_t transfer_id);
};
ValueDeserializer(Isolate* isolate, const uint8_t* data, size_t size);
@@ -1871,11 +1861,6 @@
* blink::ScriptValueSerializer.
*/
void SetSupportsLegacyWireFormat(bool supports_legacy_wire_format);
-
- /*
- * Expect inline wasm in the data stream (rather than in-memory transfer)
- */
- void SetExpectInlineWasm(bool allow_inline_wasm);
/*
* Reads the underlying wire format version. Likely mostly to be useful to
@@ -3919,37 +3904,6 @@
typedef std::pair<std::unique_ptr<const uint8_t[]>, size_t> SerializedModule;
// A buffer that is owned by the caller.
typedef std::pair<const uint8_t*, size_t> CallerOwnedBuffer;
-
- // An opaque, native heap object for transferring wasm modules. It
- // supports move semantics, and does not support copy semantics.
- class TransferrableModule final {
- public:
- TransferrableModule(TransferrableModule&& src) = default;
- TransferrableModule(const TransferrableModule& src) = delete;
-
- TransferrableModule& operator=(TransferrableModule&& src) = default;
- TransferrableModule& operator=(const TransferrableModule& src) = delete;
-
- private:
- typedef std::pair<std::unique_ptr<const uint8_t[]>, size_t> OwnedBuffer;
- friend class WasmCompiledModule;
- TransferrableModule(OwnedBuffer&& code, OwnedBuffer&& bytes)
- : compiled_code(std::move(code)), wire_bytes(std::move(bytes)) {}
-
- OwnedBuffer compiled_code = {nullptr, 0};
- OwnedBuffer wire_bytes = {nullptr, 0};
- };
-
- // Get an in-memory, non-persistable, and context-independent (meaning,
- // suitable for transfer to another Isolate and Context) representation
- // of this wasm compiled module.
- TransferrableModule GetTransferrableModule();
-
- // Efficiently re-create a WasmCompiledModule, without recompiling, from
- // a TransferrableModule.
- static MaybeLocal<WasmCompiledModule> FromTransferrableModule(
- Isolate* isolate, const TransferrableModule&);
-
// Get the wasm-encoded bytes that were used to compile this module.
Local<String> GetWasmWireBytes();
@@ -3971,11 +3925,6 @@
static MaybeLocal<WasmCompiledModule> Compile(Isolate* isolate,
const uint8_t* start,
size_t length);
- static CallerOwnedBuffer AsCallerOwned(
- const TransferrableModule::OwnedBuffer& buff) {
- return {buff.first.get(), buff.second};
- }
-
WasmCompiledModule();
static void CheckCast(Value* obj);
};
« no previous file with comments | « no previous file | src/api.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698