Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3291)

Unified Diff: cc/trees/property_tree.h

Issue 2762123004: cc: LayerTreeHostImpl uses element id to tick animations (Closed)
Patch Set: review comments Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: cc/trees/property_tree.h
diff --git a/cc/trees/property_tree.h b/cc/trees/property_tree.h
index 7fc9432eb9e8f84dc942ccf0434f09da7fbd9652..7f22a0d66a51a201ae83a6eaa4eb1dfc53a6d1e2 100644
--- a/cc/trees/property_tree.h
+++ b/cc/trees/property_tree.h
@@ -163,9 +163,8 @@ class CC_EXPORT TransformTree final : public PropertyTree<TransformNode> {
void clear();
TransformNode* FindNodeFromElementId(ElementId id);
- void OnTransformAnimated(const gfx::Transform& transform,
- int id,
- LayerTreeImpl* layer_tree_impl);
+ bool OnTransformAnimated(ElementId element_id,
+ const gfx::Transform& transform);
// Computes the change of basis transform from node |source_id| to |dest_id|.
// This is used by scroll children to compute transform from their scroll
// parent space (source) to their parent space (destination) and it can atmost
@@ -361,10 +360,8 @@ class CC_EXPORT EffectTree final : public PropertyTree<EffectNode> {
void UpdateSurfaceContentsScale(EffectNode* node);
EffectNode* FindNodeFromElementId(ElementId id);
- void OnOpacityAnimated(float opacity, int id, LayerTreeImpl* layer_tree_impl);
- void OnFilterAnimated(const FilterOperations& filters,
- int id,
- LayerTreeImpl* layer_tree_impl);
+ bool OnOpacityAnimated(ElementId id, float opacity);
+ bool OnFilterAnimated(ElementId id, const FilterOperations& filters);
void UpdateEffects(int id);

Powered by Google App Engine
This is Rietveld 408576698