Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Unified Diff: ios/chrome/browser/reading_list/reading_list_web_state_observer.mm

Issue 2762113002: Reading List iOS: Adapt loading offline for new reload process (Closed)
Patch Set: factor code Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/chrome/browser/reading_list/reading_list_web_state_observer.mm
diff --git a/ios/chrome/browser/reading_list/reading_list_web_state_observer.mm b/ios/chrome/browser/reading_list/reading_list_web_state_observer.mm
index 58ac2e84151042de615158c96e3823be937c52a7..69f8c7528f093931bcd384583ad3afb2b48865aa 100644
--- a/ios/chrome/browser/reading_list/reading_list_web_state_observer.mm
+++ b/ios/chrome/browser/reading_list/reading_list_web_state_observer.mm
@@ -295,8 +295,8 @@ void ReadingListWebStateObserver::LoadOfflineReadingListEntry() {
item = navigationManager->GetLastCommittedItem();
item->SetURL(url);
item->SetVirtualURL(pending_url_);
- navigationManager->Reload(web::ReloadType::NORMAL,
Eugene But (OOO till 7-30) 2017/03/21 15:48:19 The fact that Reload does not work anymore looks l
Olivier 2017/03/21 16:41:31 The problem here is that navigationManager->Reloa
Eugene But (OOO till 7-30) 2017/03/21 17:10:24 Thank you for explanation. I asked Kurt if this is
- false /*check_for_repost*/);
+ navigationManager->GoToIndex(
+ navigationManager->GetLastCommittedItemIndex());
} else if (navigationManager->GetPendingItemIndex() != -1 &&
navigationManager->GetItemAtIndex(
navigationManager->GetPendingItemIndex()) == item) {
« no previous file with comments | « no previous file | ios/chrome/browser/ui/reading_list/BUILD.gn » ('j') | ios/web/web_state/ui/crw_web_controller.mm » ('J')

Powered by Google App Engine
This is Rietveld 408576698