ios/chrome/browser/reading_list/reading_list_web_state_observer.mm - Issue 2762113002: Reading List iOS: Adapt loading offline for new reload process

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ios/chrome/browser/reading_list/reading_list_web_state_observer.mm

Issue 2762113002: Reading List iOS: Adapt loading offline for new reload process (Closed)

Patch Set: fix DCHECK Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ios/chrome/browser/reading_list/reading_list_web_state_observer.mm

diff --git a/ios/chrome/browser/reading_list/reading_list_web_state_observer.mm b/ios/chrome/browser/reading_list/reading_list_web_state_observer.mm

index 58ac2e84151042de615158c96e3823be937c52a7..69f8c7528f093931bcd384583ad3afb2b48865aa 100644

--- a/ios/chrome/browser/reading_list/reading_list_web_state_observer.mm

+++ b/ios/chrome/browser/reading_list/reading_list_web_state_observer.mm

@@ -295,8 +295,8 @@ void ReadingListWebStateObserver::LoadOfflineReadingListEntry() {

item = navigationManager->GetLastCommittedItem();

item->SetURL(url);

item->SetVirtualURL(pending_url_);

- navigationManager->Reload(web::ReloadType::NORMAL,

- false /*check_for_repost*/);

+ navigationManager->GoToIndex(

+ navigationManager->GetLastCommittedItemIndex());

} else if (navigationManager->GetPendingItemIndex() != -1 &&

navigationManager->GetItemAtIndex(

navigationManager->GetPendingItemIndex()) == item) {