Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(779)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2762103003: fasta.BeginGroupToken implement analyzer.BeginToken (Closed)

Created:
3 years, 9 months ago by danrubel
Modified:
3 years, 9 months ago
Reviewers:
ahe, Paul Berry
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

fasta.BeginGroupToken implement analyzer.BeginToken * fasta.BeginGroupToken implement analyzer.BeginToken * update token translator initialization of head and tail EOF * update fasta.Token value() and type accessor to match analyzer R=paulberry@google.com Committed: https://github.com/dart-lang/sdk/commit/99336edc7975ce3ee3fb77dc90b00a3e06c5e733

Patch Set 1 #

Total comments: 2

Patch Set 2 : rebase and address comment #

Patch Set 3 : merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -5 lines) Patch
M pkg/analyzer/lib/src/fasta/token_utils.dart View 2 chunks +2 lines, -0 lines 0 comments Download
M pkg/front_end/lib/src/fasta/scanner/token.dart View 1 4 chunks +40 lines, -4 lines 0 comments Download
M pkg/front_end/test/precedence_info_test.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
danrubel
3 years, 9 months ago (2017-03-21 12:20:45 UTC) #2
Paul Berry
lgtm assuming cast is removed. https://codereview.chromium.org/2762103003/diff/1/pkg/front_end/lib/src/fasta/scanner/token.dart File pkg/front_end/lib/src/fasta/scanner/token.dart (right): https://codereview.chromium.org/2762103003/diff/1/pkg/front_end/lib/src/fasta/scanner/token.dart#newcode292 pkg/front_end/lib/src/fasta/scanner/token.dart:292: endGroup = token as ...
3 years, 9 months ago (2017-03-21 14:16:01 UTC) #3
danrubel
Committed patchset #2 (id:20001) manually as 99336edc7975ce3ee3fb77dc90b00a3e06c5e733 (presubmit successful).
3 years, 9 months ago (2017-03-21 15:46:53 UTC) #5
danrubel
https://codereview.chromium.org/2762103003/diff/1/pkg/front_end/lib/src/fasta/scanner/token.dart File pkg/front_end/lib/src/fasta/scanner/token.dart (right): https://codereview.chromium.org/2762103003/diff/1/pkg/front_end/lib/src/fasta/scanner/token.dart#newcode292 pkg/front_end/lib/src/fasta/scanner/token.dart:292: endGroup = token as Token; On 2017/03/21 14:16:01, Paul ...
3 years, 9 months ago (2017-03-21 15:49:24 UTC) #6
ahe
3 years, 9 months ago (2017-03-22 08:55:44 UTC) #7
Message was sent while issue was closed. 
lgtm

Powered by Google App Engine
This is Rietveld 408576698