Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(566)

Unified Diff: ios/web_view/internal/translate/web_view_translate_client.mm

Issue 2762023003: Enable ARC for //ios/web_view/internal/translate/*.m. (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/web_view/internal/translate/web_view_translate_client.mm
diff --git a/ios/web_view/internal/translate/web_view_translate_client.mm b/ios/web_view/internal/translate/web_view_translate_client.mm
index 188e9de88cbafa496ea03cdbc858220934796e95..79f260715db0dd6d6ba9442911b12d032a8fe443 100644
--- a/ios/web_view/internal/translate/web_view_translate_client.mm
+++ b/ios/web_view/internal/translate/web_view_translate_client.mm
@@ -26,6 +26,10 @@
#import "ios/web_view/public/cwv_translate_delegate.h"
#include "url/gurl.h"
+#if !defined(__has_feature) || !__has_feature(objc_arc)
+#error "This file requires ARC support."
+#endif
+
DEFINE_WEB_STATE_USER_DATA_KEY(ios_web_view::WebViewTranslateClient);
namespace ios_web_view {
@@ -37,7 +41,8 @@ WebViewTranslateClient::WebViewTranslateClient(web::WebState* web_state)
prefs::kAcceptLanguages)),
translate_driver_(web_state,
web_state->GetNavigationManager(),
- translate_manager_.get()) {}
+ translate_manager_.get()),
+ delegate_(nil) {}
michaeldo 2017/03/21 16:29:18 please fix closing paren location and format to li
Hiroshi Ichikawa 2017/03/22 01:32:16 Removed after switching to WeakNSProtocol.
WebViewTranslateClient::~WebViewTranslateClient() = default;

Powered by Google App Engine
This is Rietveld 408576698