Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(937)

Side by Side Diff: ios/web_view/internal/translate/web_view_translate_client.h

Issue 2762023003: Enable ARC for //ios/web_view/internal/translate/*.m. (Closed)
Patch Set: Apply review comments. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef IOS_WEB_VIEW_INTERNAL_TRANSLATE_WEB_VIEW_TRANSLATE_CLIENT_H_ 5 #ifndef IOS_WEB_VIEW_INTERNAL_TRANSLATE_WEB_VIEW_TRANSLATE_CLIENT_H_
6 #define IOS_WEB_VIEW_INTERNAL_TRANSLATE_WEB_VIEW_TRANSLATE_CLIENT_H_ 6 #define IOS_WEB_VIEW_INTERNAL_TRANSLATE_WEB_VIEW_TRANSLATE_CLIENT_H_
7 7
8 #include <memory> 8 #include <memory>
9 #include <string> 9 #include <string>
10 10
11 #import "base/ios/weak_nsobject.h"
11 #include "components/translate/core/browser/translate_client.h" 12 #include "components/translate/core/browser/translate_client.h"
12 #include "components/translate/core/browser/translate_step.h" 13 #include "components/translate/core/browser/translate_step.h"
13 #include "components/translate/core/common/translate_errors.h" 14 #include "components/translate/core/common/translate_errors.h"
14 #import "components/translate/ios/browser/ios_translate_driver.h" 15 #import "components/translate/ios/browser/ios_translate_driver.h"
15 #include "ios/web/public/web_state/web_state_observer.h" 16 #include "ios/web/public/web_state/web_state_observer.h"
16 #import "ios/web/public/web_state/web_state_user_data.h" 17 #import "ios/web/public/web_state/web_state_user_data.h"
18 #import "ios/web_view/public/cwv_translate_delegate.h"
17 19
18 @protocol CWVTranslateDelegate;
19 class PrefService; 20 class PrefService;
20 21
21 namespace translate { 22 namespace translate {
22 class TranslateAcceptLanguages; 23 class TranslateAcceptLanguages;
23 class TranslatePrefs; 24 class TranslatePrefs;
24 class TranslateManager; 25 class TranslateManager;
25 } // namespace translate 26 } // namespace translate
26 27
27 namespace web { 28 namespace web {
28 class WebState; 29 class WebState;
29 } 30 }
30 31
31 namespace ios_web_view { 32 namespace ios_web_view {
32 33
33 class WebViewTranslateClient 34 class WebViewTranslateClient
34 : public translate::TranslateClient, 35 : public translate::TranslateClient,
35 public web::WebStateObserver, 36 public web::WebStateObserver,
36 public web::WebStateUserData<WebViewTranslateClient> { 37 public web::WebStateUserData<WebViewTranslateClient> {
37 public: 38 public:
38 // Sets the delegate passed by the embedder. 39 // Sets the delegate passed by the embedder.
39 // |delegate| is assumed to outlive this WebViewTranslateClient. 40 // |delegate| is assumed to outlive this WebViewTranslateClient.
40 void set_translate_delegate(id<CWVTranslateDelegate> delegate) { 41 void set_translate_delegate(id<CWVTranslateDelegate> delegate) {
41 delegate_ = delegate; 42 delegate_.reset(delegate);
42 } 43 }
43 44
44 private: 45 private:
45 friend class web::WebStateUserData<WebViewTranslateClient>; 46 friend class web::WebStateUserData<WebViewTranslateClient>;
46 47
47 // The lifetime of WebViewTranslateClient is managed by WebStateUserData. 48 // The lifetime of WebViewTranslateClient is managed by WebStateUserData.
48 explicit WebViewTranslateClient(web::WebState* web_state); 49 explicit WebViewTranslateClient(web::WebState* web_state);
49 ~WebViewTranslateClient() override; 50 ~WebViewTranslateClient() override;
50 51
51 // TranslateClient implementation. 52 // TranslateClient implementation.
(...skipping 13 matching lines...) Expand all
65 bool IsTranslatableURL(const GURL& url) override; 66 bool IsTranslatableURL(const GURL& url) override;
66 void ShowReportLanguageDetectionErrorUI(const GURL& report_url) override; 67 void ShowReportLanguageDetectionErrorUI(const GURL& report_url) override;
67 68
68 // web::WebStateObserver implementation. 69 // web::WebStateObserver implementation.
69 void WebStateDestroyed() override; 70 void WebStateDestroyed() override;
70 71
71 std::unique_ptr<translate::TranslateManager> translate_manager_; 72 std::unique_ptr<translate::TranslateManager> translate_manager_;
72 translate::IOSTranslateDriver translate_driver_; 73 translate::IOSTranslateDriver translate_driver_;
73 74
74 // Delegate provided by the embedder. 75 // Delegate provided by the embedder.
75 id<CWVTranslateDelegate> delegate_; // Weak. 76 base::WeakNSProtocol<id<CWVTranslateDelegate>> delegate_;
76 77
77 DISALLOW_COPY_AND_ASSIGN(WebViewTranslateClient); 78 DISALLOW_COPY_AND_ASSIGN(WebViewTranslateClient);
78 }; 79 };
79 80
80 } // namespace ios_web_view 81 } // namespace ios_web_view
81 82
82 #endif // IOS_WEB_VIEW_INTERNAL_TRANSLATE_WEB_VIEW_TRANSLATE_CLIENT_H_ 83 #endif // IOS_WEB_VIEW_INTERNAL_TRANSLATE_WEB_VIEW_TRANSLATE_CLIENT_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698