Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2761973002: Read and write connection ID (represented as uint64_t) in network byte order (big endian). Protecte… (Closed)

Created:
3 years, 9 months ago by Ryan Hamilton
Modified:
3 years, 8 months ago
Reviewers:
Jana
CC:
chromium-reviews, cbentzel+watch_chromium.org, net-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Read and write connection ID (represented as uint64_t) in network byte order (big endian). Protected by FLAGS_quic_restart_flag_quic_big_endian_connection_id. Merge internal change: 150218161

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2013 lines, -190 lines) Patch
M net/quic/core/quic_data_reader.h View 1 chunk +9 lines, -0 lines 0 comments Download
M net/quic/core/quic_data_reader.cc View 2 chunks +14 lines, -0 lines 0 comments Download
M net/quic/core/quic_data_writer.h View 1 chunk +6 lines, -0 lines 0 comments Download
M net/quic/core/quic_data_writer.cc View 2 chunks +11 lines, -0 lines 0 comments Download
M net/quic/core/quic_data_writer_test.cc View 2 chunks +26 lines, -0 lines 0 comments Download
M net/quic/core/quic_flags_list.h View 1 chunk +4 lines, -0 lines 0 comments Download
M net/quic/core/quic_framer.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M net/quic/core/quic_framer_test.cc View 90 chunks +1939 lines, -186 lines 0 comments Download

Dependent Patchsets:

Issue 2764653002 Patch 1

Messages

Total messages: 7 (3 generated)
Ryan Hamilton
3 years, 9 months ago (2017-03-20 22:27:20 UTC) #2
Jana
lgtm
3 years, 9 months ago (2017-03-20 22:49:10 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2761973002/1
3 years, 8 months ago (2017-03-27 16:58:26 UTC) #5
commit-bot: I haz the power
3 years, 8 months ago (2017-03-27 17:02:04 UTC) #7 
Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

Powered by Google App Engine
This is Rietveld 408576698