Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1804)

Unified Diff: runtime/vm/kernel_to_il.cc

Issue 2761933002: Add Genericity enum in VM to distinguish how a type is uninstantiated. (Closed)
Patch Set: sync Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/jit_optimizer.cc ('k') | runtime/vm/object.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/kernel_to_il.cc
diff --git a/runtime/vm/kernel_to_il.cc b/runtime/vm/kernel_to_il.cc
index b2898b85b251e0ba75f4e3255ce55628c74645d0..e4204fd6539343ecb732169d47736cbaf6724221 100644
--- a/runtime/vm/kernel_to_il.cc
+++ b/runtime/vm/kernel_to_il.cc
@@ -2112,8 +2112,9 @@ Fragment FlowGraphBuilder::LoadInstantiatorTypeArguments() {
Fragment FlowGraphBuilder::InstantiateType(const AbstractType& type) {
- InstantiateTypeInstr* instr = new (Z) InstantiateTypeInstr(
- TokenPosition::kNoSource, type, *active_class_.klass, Pop());
+ InstantiateTypeInstr* instr = new (Z)
+ InstantiateTypeInstr(TokenPosition::kNoSource, type, Pop(),
+ NULL); // TODO(regis): Pop function type arguments.
Push(instr);
return Fragment(instr);
}
@@ -2122,7 +2123,8 @@ Fragment FlowGraphBuilder::InstantiateType(const AbstractType& type) {
Fragment FlowGraphBuilder::InstantiateTypeArguments(
const TypeArguments& type_arguments) {
InstantiateTypeArgumentsInstr* instr = new (Z) InstantiateTypeArgumentsInstr(
- TokenPosition::kNoSource, type_arguments, *active_class_.klass, Pop());
+ TokenPosition::kNoSource, type_arguments, *active_class_.klass, Pop(),
+ NULL); // TODO(regis): Pop function type arguments.
Push(instr);
return Fragment(instr);
}
@@ -3737,6 +3739,7 @@ Fragment FlowGraphBuilder::AssertAssignable(const dart::AbstractType& dst_type,
AssertAssignableInstr* instr = new (Z)
AssertAssignableInstr(TokenPosition::kNoSource, value, type_args,
+ NULL, // TODO(regis): Pop function type arguments.
dst_type, dst_name, H.thread()->GetNextDeoptId());
Push(instr);
« no previous file with comments | « runtime/vm/jit_optimizer.cc ('k') | runtime/vm/object.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698