Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1046)

Unified Diff: runtime/vm/jit_optimizer.cc

Issue 2761933002: Add Genericity enum in VM to distinguish how a type is uninstantiated. (Closed)
Patch Set: sync Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/intermediate_language.cc ('k') | runtime/vm/kernel_to_il.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/jit_optimizer.cc
diff --git a/runtime/vm/jit_optimizer.cc b/runtime/vm/jit_optimizer.cc
index 4d8ca8998438c37e40856eff17f91afb98e2da31..0b9cfea4d123d5c2dd0955545fdb0c22f6044ad4 100644
--- a/runtime/vm/jit_optimizer.cc
+++ b/runtime/vm/jit_optimizer.cc
@@ -1394,9 +1394,10 @@ void JitOptimizer::ReplaceWithInstanceOf(InstanceCallInstr* call) {
return;
}
- InstanceOfInstr* instance_of =
- new (Z) InstanceOfInstr(call->token_pos(), new (Z) Value(left),
- new (Z) Value(type_args), type, call->deopt_id());
+ InstanceOfInstr* instance_of = new (Z) InstanceOfInstr(
+ call->token_pos(), new (Z) Value(left), new (Z) Value(type_args),
+ NULL, // TODO(regis): Pass function type args.
+ type, call->deopt_id());
ReplaceCall(call, instance_of);
}
@@ -1434,8 +1435,9 @@ void JitOptimizer::ReplaceWithTypeCast(InstanceCallInstr* call) {
}
}
AssertAssignableInstr* assert_as = new (Z) AssertAssignableInstr(
- call->token_pos(), new (Z) Value(left), new (Z) Value(type_args), type,
- Symbols::InTypeCast(), call->deopt_id());
+ call->token_pos(), new (Z) Value(left), new (Z) Value(type_args),
+ NULL, // TODO(regis): Pass function type arguments.
+ type, Symbols::InTypeCast(), call->deopt_id());
ReplaceCall(call, assert_as);
}
« no previous file with comments | « runtime/vm/intermediate_language.cc ('k') | runtime/vm/kernel_to_il.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698