Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(271)

Issue 2761933002: Add Genericity enum in VM to distinguish how a type is uninstantiated. (Closed)

Created:
3 years, 9 months ago by regis
Modified:
3 years, 9 months ago
Reviewers:
rmacnak, siva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add Genericity enum in VM to distinguish how a type is uninstantiated. Make flow graph builder aware of function type arguments. This is work in progress toward supporting generic method semantics in the VM. R=rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/9c9a14a29ae6b458022aa4ce69790cddd0ab502d

Patch Set 1 #

Patch Set 2 : sync #

Unified diffs Side-by-side diffs Delta from patch set Stats (+204 lines, -144 lines) Patch
M runtime/vm/aot_optimizer.cc View 2 chunks +7 lines, -5 lines 0 comments Download
M runtime/vm/constant_propagator.cc View 2 chunks +6 lines, -2 lines 0 comments Download
M runtime/vm/flow_graph_builder.h View 1 chunk +6 lines, -8 lines 0 comments Download
M runtime/vm/flow_graph_builder.cc View 11 chunks +75 lines, -82 lines 0 comments Download
M runtime/vm/flow_graph_inliner.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M runtime/vm/il_printer.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M runtime/vm/intermediate_language.h View 1 6 chunks +15 lines, -11 lines 0 comments Download
M runtime/vm/intermediate_language.cc View 1 3 chunks +5 lines, -1 line 0 comments Download
M runtime/vm/jit_optimizer.cc View 2 chunks +7 lines, -5 lines 0 comments Download
M runtime/vm/kernel_to_il.cc View 1 3 chunks +6 lines, -3 lines 0 comments Download
M runtime/vm/object.h View 1 8 chunks +28 lines, -8 lines 0 comments Download
M runtime/vm/object.cc View 1 10 chunks +44 lines, -9 lines 0 comments Download
M runtime/vm/parser.cc View 1 chunk +2 lines, -8 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
regis
3 years, 9 months ago (2017-03-20 19:28:06 UTC) #2
rmacnak
LGTM
3 years, 9 months ago (2017-03-21 17:13:10 UTC) #3
regis
Thanks! I just renamed kFunction to kFunctions before committing, as it is clearer.
3 years, 9 months ago (2017-03-21 17:19:09 UTC) #4
regis
3 years, 9 months ago (2017-03-21 17:20:13 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
9c9a14a29ae6b458022aa4ce69790cddd0ab502d (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698