Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(255)

Issue 276193002: Add a use counter for VTTCue right-to-left rendering (Closed)

Created:
6 years, 7 months ago by philipj_slow
Modified:
6 years, 7 months ago
Reviewers:
fs
CC:
blink-reviews, nessy, blink-reviews-html_chromium.org, gasubic, fs, eric.carlson_apple.com, dglazkov+blink, vcarbune.chromium, philipj_slow
Visibility:
Public.

Description

Add a use counter for VTTCue right-to-left rendering The WebVTT position model has been changed: https://www.w3.org/Bugs/Public/show_bug.cgi?id=20037 In order to ship this (or any alternative) we need to know that it doesn't break too much, and right-to-left text used to flip the interpretation of the position setting, but doesn't any longer. BUG=none Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=173841

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M Source/core/frame/UseCounter.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/html/track/vtt/VTTCue.cpp View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
philipj_slow
6 years, 7 months ago (2014-05-10 21:46:00 UTC) #1
fs
LGTM
6 years, 7 months ago (2014-05-11 20:23:18 UTC) #2
philipj_slow
The CQ bit was checked by philipj@opera.com
6 years, 7 months ago (2014-05-11 20:28:45 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/276193002/1
6 years, 7 months ago (2014-05-11 20:28:49 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-11 21:11:02 UTC) #5
commit-bot: I haz the power
Change committed as 173841
6 years, 7 months ago (2014-05-11 21:49:11 UTC) #6
commit-bot: I haz the power
6 years, 7 months ago (2014-05-11 21:49:26 UTC) #7
Message was sent while issue was closed.
Failed to apply patch for Source/core/frame/UseCounter.h:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file Source/core/frame/UseCounter.h
  Hunk #1 FAILED at 420.
  1 out of 1 hunk FAILED -- saving rejects to file
Source/core/frame/UseCounter.h.rej

Patch:       Source/core/frame/UseCounter.h
Index: Source/core/frame/UseCounter.h
diff --git a/Source/core/frame/UseCounter.h b/Source/core/frame/UseCounter.h
index
bb030c5917caab40408b7802b8bc36698920fc44..c1d8d3ac32d5f68732382a1de7389d9bd77af365
100644
--- a/Source/core/frame/UseCounter.h
+++ b/Source/core/frame/UseCounter.h
@@ -420,6 +420,7 @@ public:
         VTTCueRenderSizeNot100 = 415,
         VTTCueRenderAlignNotMiddle = 416,
         ElementRequestPointerLock = 417,
+        VTTCueRenderRtl = 418,
         // Add new features immediately above this line. Don't change assigned
         // numbers of any item, and don't reuse removed slots.
         // Also, run update_use_counter_feature_enum.py in
chromium/src/tools/metrics/histograms/

Powered by Google App Engine
This is Rietveld 408576698