Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(317)

Issue 2761923002: [LayoutNG] Refactor NGBlockLayoutAlgorithm::PrepareChildLayout() (Closed)

Created:
3 years, 9 months ago by ikilpatrick
Modified:
3 years, 8 months ago
Reviewers:
cbiesinger, Gleb Lanbin
CC:
chromium-reviews, cbiesinger, ojan+watch_chromium.org, szager+layoutwatch_chromium.org, glebl+reviews_chromium.org, dgrogan+ng_chromium.org, atotic+reviews_chromium.org, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, zoltan1, jchaffraix+rendering, blink-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[LayoutNG] Refactor NGBlockLayoutAlgorithm::PrepareChildLayout() Additionally this only flushes the pending floats if the child is actually going to clear something. BUG=635619 Review-Url: https://codereview.chromium.org/2761923002 Cr-Commit-Position: refs/heads/master@{#461617} Committed: https://chromium.googlesource.com/chromium/src/+/475dd3c192ae74c88eadf7c4284c9660858f1adc

Patch Set 1 #

Patch Set 2 : more test #

Patch Set 3 : blah. #

Patch Set 4 : moar test. #

Patch Set 5 : lalalala. #

Patch Set 6 : [LayoutNG] Refactor PrepareChildLayout(). #

Total comments: 24

Patch Set 7 : address comments. #

Patch Set 8 : rebase. #

Patch Set 9 : update expectations and add comment about corner case. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+233 lines, -119 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 2 3 4 5 6 7 8 2 chunks +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.cc View 1 2 3 4 5 6 7 8 7 chunks +84 lines, -44 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm_test.cc View 1 2 3 4 5 6 7 3 chunks +87 lines, -31 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_floating_object.h View 1 2 3 4 5 6 7 1 chunk +4 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_inline_layout_algorithm.cc View 1 2 3 4 5 6 7 2 chunks +8 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_layout_input_node.h View 1 2 3 4 5 6 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_space_utils.h View 1 2 3 4 5 6 7 2 chunks +10 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_space_utils.cc View 1 2 3 4 5 6 7 5 chunks +15 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_space_utils_test.cc View 1 2 3 4 5 6 7 1 chunk +20 lines, -19 lines 0 comments Download

Messages

Total messages: 25 (19 generated)
ikilpatrick
https://codereview.chromium.org/2761923002/diff/100001/third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.cc File third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.cc (right): https://codereview.chromium.org/2761923002/diff/100001/third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.cc#newcode431 third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.cc:431: UpdateFragmentBfcOffset(curr_bfc_offset_); I moved this here as it was confusing ...
3 years, 9 months ago (2017-03-23 19:24:15 UTC) #3
Gleb Lanbin
lgtm with minor comments https://codereview.chromium.org/2761923002/diff/100001/third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.cc File third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.cc (right): https://codereview.chromium.org/2761923002/diff/100001/third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.cc#newcode73 third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.cc:73: const NGFragmentBuilder& builder, should we ...
3 years, 9 months ago (2017-03-23 20:32:25 UTC) #4
cbiesinger
https://codereview.chromium.org/2761923002/diff/100001/third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.cc File third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.cc (right): https://codereview.chromium.org/2761923002/diff/100001/third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.cc#newcode78 third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.cc:78: if (exclusions.last_left_float && On 2017/03/23 20:32:25, Gleb Lanbin wrote: ...
3 years, 9 months ago (2017-03-23 21:03:07 UTC) #6
ikilpatrick
https://codereview.chromium.org/2761923002/diff/100001/third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.cc File third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.cc (right): https://codereview.chromium.org/2761923002/diff/100001/third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.cc#newcode73 third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.cc:73: const NGFragmentBuilder& builder, On 2017/03/23 20:32:24, Gleb Lanbin wrote: ...
3 years, 9 months ago (2017-03-24 23:30:39 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2761923002/160001
3 years, 8 months ago (2017-04-04 01:46:24 UTC) #22
commit-bot: I haz the power
3 years, 8 months ago (2017-04-04 02:53:09 UTC) #25
Message was sent while issue was closed.
Committed patchset #9 (id:160001) as
https://chromium.googlesource.com/chromium/src/+/475dd3c192ae74c88eadf7c4284c...

Powered by Google App Engine
This is Rietveld 408576698