third_party/WebKit/Source/core/paint/BoxPaintInvalidator.cpp - Issue 2761863002: Add StyleDifference::needsVisualRectUpdate

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/paint/BoxPaintInvalidator.cpp

Issue 2761863002: Add StyleDifference::needsVisualRectUpdate (Closed)

Patch Set: Still keep visibility change detection for full paint invalidation. Will optimize in later CLs Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/paint/BoxPaintInvalidator.cpp

diff --git a/third_party/WebKit/Source/core/paint/BoxPaintInvalidator.cpp b/third_party/WebKit/Source/core/paint/BoxPaintInvalidator.cpp

index 0e6a2bebc9c206f82ea9645f91250e3e3c73b5fd..96432ee50312689f1eaaf9cfbd4b74b02ee2f96f 100644

--- a/third_party/WebKit/Source/core/paint/BoxPaintInvalidator.cpp

+++ b/third_party/WebKit/Source/core/paint/BoxPaintInvalidator.cpp

@@ -125,8 +125,7 @@ PaintInvalidationReason BoxPaintInvalidator::computePaintInvalidationReason() {

DCHECK(borderBoxChanged);

if (style.hasVisualOverflowingEffect() || style.hasAppearance() ||

- style.hasFilterInducingProperty() || style.resize() != RESIZE_NONE ||

- style.hasMask())

+ style.hasFilterInducingProperty() || style.hasMask())

return PaintInvalidationBorderBoxChange;

if (style.hasBorderRadius())