Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1145)

Unified Diff: pkg/polymer/lib/src/instance.dart

Issue 27618002: package:observe fix various api issues (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/polymer/lib/src/instance.dart
diff --git a/pkg/polymer/lib/src/instance.dart b/pkg/polymer/lib/src/instance.dart
index dd5c349cbcc30649f669b12731c57902579adae5..2e558a0d3715ca31e0dd7f795083a7bc0074bc3a 100644
--- a/pkg/polymer/lib/src/instance.dart
+++ b/pkg/polymer/lib/src/instance.dart
@@ -898,7 +898,7 @@ class _PolymerBinding extends NodeBinding {
void _propertyValueChanged(List<ChangeRecord> records) {
for (var record in records) {
- if (record.changes(_property)) {
+ if (record is PropertyChangeRecord && record.name == _property) {
final newValue = _target.getField(_property).reflectee;
if (!identical(_lastValue, newValue)) {
value = newValue;
@@ -942,7 +942,7 @@ final Expando _eventHandledTable = new Expando<Set<Node>>();
*
* See [Polymer].
*/
-class PolymerElement extends HtmlElement with Polymer, ObservableMixin {
+class PolymerElement extends HtmlElement with Polymer, Observable {
PolymerElement.created() : super.created() {
polymerCreated();
}

Powered by Google App Engine
This is Rietveld 408576698