Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(293)

Unified Diff: pkg/observe/lib/src/bind_property.dart

Issue 27618002: package:observe fix various api issues (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/observe/lib/src/bind_property.dart
diff --git a/pkg/observe/lib/src/bind_property.dart b/pkg/observe/lib/src/bind_property.dart
index a8e78dee3c57283b4935b3e7b25f1ff7bdda6705..b37f8c20d71e527e8bdea9e101b6ed842012dcba 100644
--- a/pkg/observe/lib/src/bind_property.dart
+++ b/pkg/observe/lib/src/bind_property.dart
@@ -7,7 +7,7 @@ part of observe;
/**
* Forwards an observable property from one object to another. For example:
*
- * class MyModel extends ObservableBase {
+ * class MyModel extends Observable {
* StreamSubscription _sub;
* MyOtherModel _otherModel;
*
@@ -28,8 +28,10 @@ StreamSubscription onPropertyChange(Observable source, Symbol sourceName,
void callback()) {
return source.changes.listen((records) {
for (var record in records) {
- if (record.changes(sourceName)) {
+ if (record is PropertyChangeRecord &&
+ (record as PropertyChangeRecord).field == sourceName) {
Siggi Cherem (dart-lang) 2013/10/17 02:04:56 use .name instead of .field? field is deprecated ;
Jennifer Messerly 2013/10/17 03:25:12 oops! done.
callback();
+ break;
}
}
});

Powered by Google App Engine
This is Rietveld 408576698