Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Unified Diff: ios/chrome/browser/ui/content_suggestions/cells/BUILD.gn

Issue 2761753002: Cleanup ContentSuggestions cells (Closed)
Patch Set: Fix tests Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/chrome/browser/ui/content_suggestions/cells/BUILD.gn
diff --git a/ios/chrome/browser/ui/content_suggestions/BUILD.gn b/ios/chrome/browser/ui/content_suggestions/cells/BUILD.gn
similarity index 65%
copy from ios/chrome/browser/ui/content_suggestions/BUILD.gn
copy to ios/chrome/browser/ui/content_suggestions/cells/BUILD.gn
index 4c1aa80e9709a24880e655b5763dc892783d5a6d..2bf013907a137c5a1bbec0dece1d98e19c629a8a 100644
--- a/ios/chrome/browser/ui/content_suggestions/BUILD.gn
+++ b/ios/chrome/browser/ui/content_suggestions/cells/BUILD.gn
@@ -1,19 +1,14 @@
-# Copyright 2016 The Chromium Authors. All rights reserved.
+# Copyright 2017 The Chromium Authors. All rights reserved.
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.
-source_set("content_suggestions") {
- configs += [ "//build/config/compiler:enable_arc" ]
+source_set("cells") {
sources = [
- "content_suggestion.h",
- "content_suggestion.mm",
"content_suggestions_article_item.h",
"content_suggestions_article_item.mm",
- "content_suggestions_collection_updater.h",
- "content_suggestions_collection_updater.mm",
- "content_suggestions_commands.h",
- "content_suggestions_data_sink.h",
- "content_suggestions_data_source.h",
+ "content_suggestions_button_item.h",
+ "content_suggestions_button_item.mm",
+ "content_suggestions_button_item_actions.h",
"content_suggestions_expandable_item.h",
"content_suggestions_expandable_item.mm",
"content_suggestions_favicon_internal_cell.h",
@@ -22,15 +17,9 @@ source_set("content_suggestions") {
"content_suggestions_favicon_item.mm",
"content_suggestions_footer_item.h",
"content_suggestions_footer_item.mm",
- "content_suggestions_image_fetcher.h",
"content_suggestions_stack_item.h",
"content_suggestions_stack_item.mm",
"content_suggestions_stack_item_actions.h",
- "content_suggestions_text_item.h",
- "content_suggestions_text_item.mm",
- "content_suggestions_text_item_actions.h",
- "content_suggestions_view_controller.h",
- "content_suggestions_view_controller.mm",
"expandable_item.h",
]
deps = [
@@ -40,32 +29,29 @@ source_set("content_suggestions") {
"//ios/chrome/browser/ui/colors",
"//ios/chrome/browser/ui/content_suggestions/identifier",
"//ios/chrome/browser/ui/util",
- "//ios/third_party/material_roboto_font_loader_ios",
"//ui/base",
"//url",
]
- public_deps = [
- "//ios/third_party/material_components_ios",
- ]
+ configs += [ "//build/config/compiler:enable_arc" ]
}
source_set("unit_tests") {
- configs += [ "//build/config/compiler:enable_arc" ]
testonly = true
sources = [
"content_suggestions_article_item_unittest.mm",
+ "content_suggestions_button_item_unittest.mm",
"content_suggestions_expandable_item_unittest.mm",
"content_suggestions_favicon_item_unittest.mm",
"content_suggestions_footer_item_unittest.mm",
"content_suggestions_stack_item_unittest.mm",
- "content_suggestions_text_item_unittest.mm",
]
deps = [
- ":content_suggestions",
+ ":cells",
"//base",
"//ios/chrome/browser/ui/collection_view",
"//testing/gtest",
"//third_party/ocmock",
"//url",
]
+ configs += [ "//build/config/compiler:enable_arc" ]
}

Powered by Google App Engine
This is Rietveld 408576698