Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Side by Side Diff: ios/chrome/browser/ui/content_suggestions/cells/BUILD.gn

Issue 2761753002: Cleanup ContentSuggestions cells (Closed)
Patch Set: Move unit tests Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright 2016 The Chromium Authors. All rights reserved. 1 # Copyright 2017 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 source_set("content_suggestions") { 5 source_set("cells") {
6 configs += [ "//build/config/compiler:enable_arc" ] 6 configs += [ "//build/config/compiler:enable_arc" ]
7 sources = [ 7 sources = [
8 "content_suggestion.h",
9 "content_suggestion.mm",
10 "content_suggestion_identifier.h", 8 "content_suggestion_identifier.h",
11 "content_suggestion_identifier.mm", 9 "content_suggestion_identifier.mm",
12 "content_suggestions_article_item.h", 10 "content_suggestions_article_item.h",
13 "content_suggestions_article_item.mm", 11 "content_suggestions_article_item.mm",
14 "content_suggestions_collection_updater.h", 12 "content_suggestions_button_item.h",
15 "content_suggestions_collection_updater.mm", 13 "content_suggestions_button_item.mm",
16 "content_suggestions_commands.h", 14 "content_suggestions_button_item_actions.h",
17 "content_suggestions_data_sink.h",
18 "content_suggestions_data_source.h",
19 "content_suggestions_expandable_item.h", 15 "content_suggestions_expandable_item.h",
20 "content_suggestions_expandable_item.mm", 16 "content_suggestions_expandable_item.mm",
21 "content_suggestions_favicon_internal_cell.h", 17 "content_suggestions_favicon_internal_cell.h",
22 "content_suggestions_favicon_internal_cell.mm", 18 "content_suggestions_favicon_internal_cell.mm",
23 "content_suggestions_favicon_item.h", 19 "content_suggestions_favicon_item.h",
24 "content_suggestions_favicon_item.mm", 20 "content_suggestions_favicon_item.mm",
25 "content_suggestions_footer_item.h", 21 "content_suggestions_footer_item.h",
26 "content_suggestions_footer_item.mm", 22 "content_suggestions_footer_item.mm",
27 "content_suggestions_image_fetcher.h",
28 "content_suggestions_section_information.h",
29 "content_suggestions_section_information.mm",
30 "content_suggestions_stack_item.h", 23 "content_suggestions_stack_item.h",
31 "content_suggestions_stack_item.mm", 24 "content_suggestions_stack_item.mm",
32 "content_suggestions_stack_item_actions.h", 25 "content_suggestions_stack_item_actions.h",
33 "content_suggestions_text_item.h",
34 "content_suggestions_text_item.mm",
35 "content_suggestions_text_item_actions.h",
36 "content_suggestions_view_controller.h",
37 "content_suggestions_view_controller.mm",
38 "expandable_item.h", 26 "expandable_item.h",
39 ] 27 ]
40 deps = [ 28 deps = [
41 "//base", 29 "//base",
42 "//ios/chrome/browser/ui", 30 "//ios/chrome/browser/ui",
lpromero 2017/03/20 11:41:50 Is this needed? Can you make a pass on each?
gambard 2017/03/20 15:04:15 Done.
43 "//ios/chrome/browser/ui/collection_view", 31 "//ios/chrome/browser/ui/collection_view",
44 "//ios/chrome/browser/ui/colors", 32 "//ios/chrome/browser/ui/colors",
45 "//ios/chrome/browser/ui/util", 33 "//ios/chrome/browser/ui/util",
46 "//ios/third_party/material_roboto_font_loader_ios", 34 "//ios/third_party/material_roboto_font_loader_ios",
47 "//ui/base", 35 "//ui/base",
48 "//url", 36 "//url",
49 ] 37 ]
50 public_deps = [ 38 public_deps = [
51 "//ios/third_party/material_components_ios", 39 "//ios/third_party/material_components_ios",
52 ] 40 ]
53 } 41 }
54 42
55 source_set("unit_tests") { 43 source_set("unit_tests") {
56 configs += [ "//build/config/compiler:enable_arc" ] 44 configs += [ "//build/config/compiler:enable_arc" ]
57 testonly = true 45 testonly = true
58 sources = [ 46 sources = [
59 "content_suggestion_identifier_unittest.mm", 47 "content_suggestion_identifier_unittest.mm",
60 "content_suggestions_article_item_unittest.mm", 48 "content_suggestions_article_item_unittest.mm",
49 "content_suggestions_button_item_unittest.mm",
61 "content_suggestions_expandable_item_unittest.mm", 50 "content_suggestions_expandable_item_unittest.mm",
62 "content_suggestions_favicon_item_unittest.mm", 51 "content_suggestions_favicon_item_unittest.mm",
63 "content_suggestions_footer_item_unittest.mm", 52 "content_suggestions_footer_item_unittest.mm",
64 "content_suggestions_stack_item_unittest.mm", 53 "content_suggestions_stack_item_unittest.mm",
65 "content_suggestions_text_item_unittest.mm",
66 ] 54 ]
67 deps = [ 55 deps = [
68 ":content_suggestions", 56 ":cells",
69 "//base", 57 "//base",
70 "//ios/chrome/browser/ui/collection_view", 58 "//ios/chrome/browser/ui/collection_view",
71 "//testing/gtest", 59 "//testing/gtest",
72 "//third_party/ocmock", 60 "//third_party/ocmock",
73 "//url", 61 "//url",
74 ] 62 ]
75 } 63 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698