DescriptionRevert of Linux Aura Task Manager Frame Buttons Misaligned (https://codereview.chromium.org/240163006/)
Reason for revert:
Suspected of being responsible for ash_unittests failing on Linux ChromiumOS Tests(1):
http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%281%29/builds/43114
Original issue's description:
> Linux Aura Task Manager Frame Buttons Misaligned
>
> The task manager is a CustomFrameView. This had the logic for its button
> placement hardcoded. The view now adds itself as a listener for button
> configuration changes on linux. For other systems it falls back on a
> default set that matches the current (minimize, maximize, close) order.
>
> The layout of the buttons has changed to consult this order definition.
>
> Loading the assets for the close button has been moved out of layout.
> ResourceBundle only loads the asset once, so this can be done during
> initialization.
>
> The top padding for the buttons has been updated to provide more spacing. It now fits the rest of the padding in the class.
>
> TEST=CustomFrameViewTest
> BUG=351917
>
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=269597
NOTREECHECKS=true
NOTRY=true
BUG=351917
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=269636
Patch Set 1 #
Created: 6 years, 7 months ago
(Patch set is too large to download)
Messages
Total messages: 8 (0 generated)
|