Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(342)

Issue 276173002: Revert of Linux Aura Task Manager Frame Buttons Misaligned (Closed)

Created:
6 years, 7 months ago by mdempsky
Modified:
6 years, 7 months ago
CC:
chromium-reviews, tfarina, varkha
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Revert of Linux Aura Task Manager Frame Buttons Misaligned (https://codereview.chromium.org/240163006/) Reason for revert: Suspected of being responsible for ash_unittests failing on Linux ChromiumOS Tests(1): http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%281%29/builds/43114 Original issue's description: > Linux Aura Task Manager Frame Buttons Misaligned > > The task manager is a CustomFrameView. This had the logic for its button > placement hardcoded. The view now adds itself as a listener for button > configuration changes on linux. For other systems it falls back on a > default set that matches the current (minimize, maximize, close) order. > > The layout of the buttons has changed to consult this order definition. > > Loading the assets for the close button has been moved out of layout. > ResourceBundle only loads the asset once, so this can be done during > initialization. > > The top padding for the buttons has been updated to provide more spacing. It now fits the rest of the padding in the class. > > TEST=CustomFrameViewTest > BUG=351917 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=269597 NOTREECHECKS=true NOTRY=true BUG=351917 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=269636

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+66 lines, -572 lines) Patch
D ui/views/linux_ui/window_button_order_provider.cc View 1 chunk +0 lines, -93 lines 0 comments Download
M ui/views/views.gyp View 4 chunks +0 lines, -7 lines 0 comments Download
M ui/views/window/custom_frame_view.h View 6 chunks +3 lines, -21 lines 0 comments Download
M ui/views/window/custom_frame_view.cc View 11 chunks +63 lines, -94 lines 0 comments Download
D ui/views/window/custom_frame_view_unittest.cc View 1 chunk +0 lines, -253 lines 0 comments Download
D ui/views/window/window_button_order_provider.h View 1 chunk +0 lines, -53 lines 0 comments Download
D ui/views/window/window_button_order_provider.cc View 1 chunk +0 lines, -51 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
mdempsky
Created Revert of Linux Aura Task Manager Frame Buttons Misaligned
6 years, 7 months ago (2014-05-10 20:57:37 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mdempsky@chromium.org/276173002/1
6 years, 7 months ago (2014-05-10 20:58:49 UTC) #2
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-10 20:58:50 UTC) #3
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 7 months ago (2014-05-10 20:58:51 UTC) #4
varkha
lgtm.
6 years, 7 months ago (2014-05-10 21:00:14 UTC) #5
mdempsky
The CQ bit was checked by mdempsky@chromium.org
6 years, 7 months ago (2014-05-10 21:00:41 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mdempsky@chromium.org/276173002/1
6 years, 7 months ago (2014-05-10 21:01:03 UTC) #7
commit-bot: I haz the power
6 years, 7 months ago (2014-05-10 21:02:40 UTC) #8
Message was sent while issue was closed.
Change committed as 269636

Powered by Google App Engine
This is Rietveld 408576698