third_party/WebKit/Source/modules/webdatabase/InspectorDatabaseAgent.cpp - Issue 2761693002: Wrapped PassRefPtrs in move where passed to RefPtr constructor.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/webdatabase/InspectorDatabaseAgent.cpp

Issue 2761693002: Wrapped PassRefPtrs in move where passed to RefPtr constructor. (Closed)

Patch Set: Added move wraps for multiple instances in 1 line. Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/speech/SpeechSynthesisVoice.cpp ('k') | third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/webdatabase/InspectorDatabaseAgent.cpp

diff --git a/third_party/WebKit/Source/modules/webdatabase/InspectorDatabaseAgent.cpp b/third_party/WebKit/Source/modules/webdatabase/InspectorDatabaseAgent.cpp

index 59caca34dd71a00600ca05141194980ac05a91ba..aec58dc4ee9c0b0acc7a2e1aa76b42ab9f402056 100644

--- a/third_party/WebKit/Source/modules/webdatabase/InspectorDatabaseAgent.cpp

+++ b/third_party/WebKit/Source/modules/webdatabase/InspectorDatabaseAgent.cpp

@@ -135,7 +135,7 @@ class StatementCallback final : public SQLStatementCallback {

private:

StatementCallback(PassRefPtr<ExecuteSQLCallbackWrapper> requestCallback)

- : m_requestCallback(requestCallback) {}

+ : m_requestCallback(std::move(requestCallback)) {}

RefPtr<ExecuteSQLCallbackWrapper> m_requestCallback;

};

@@ -157,7 +157,7 @@ class StatementErrorCallback final : public SQLStatementErrorCallback {

private:

StatementErrorCallback(PassRefPtr<ExecuteSQLCallbackWrapper> requestCallback)

- : m_requestCallback(requestCallback) {}

+ : m_requestCallback(std::move(requestCallback)) {}

RefPtr<ExecuteSQLCallbackWrapper> m_requestCallback;

};

@@ -187,7 +187,8 @@ class TransactionCallback final : public SQLTransactionCallback {

private:

TransactionCallback(const String& sqlStatement,

PassRefPtr<ExecuteSQLCallbackWrapper> requestCallback)

- : m_sqlStatement(sqlStatement), m_requestCallback(requestCallback) {}

+ : m_sqlStatement(sqlStatement),

+ m_requestCallback(std::move(requestCallback)) {}

String m_sqlStatement;

RefPtr<ExecuteSQLCallbackWrapper> m_requestCallback;

};

@@ -211,7 +212,7 @@ class TransactionErrorCallback final : public SQLTransactionErrorCallback {

private:

TransactionErrorCallback(

PassRefPtr<ExecuteSQLCallbackWrapper> requestCallback)

- : m_requestCallback(requestCallback) {}

+ : m_requestCallback(std::move(requestCallback)) {}

RefPtr<ExecuteSQLCallbackWrapper> m_requestCallback;

};