third_party/WebKit/Source/core/style/ShapeValue.h - Issue 2761693002: Wrapped PassRefPtrs in move where passed to RefPtr constructor.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/style/ShapeValue.h

Issue 2761693002: Wrapped PassRefPtrs in move where passed to RefPtr constructor. (Closed)

Patch Set: Added move wraps for multiple instances in 1 line. Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/style/ShapeValue.h

diff --git a/third_party/WebKit/Source/core/style/ShapeValue.h b/third_party/WebKit/Source/core/style/ShapeValue.h

index 94ada72c7f74190044683385928614a7917decfd..26c0649b5f01e9478a7510140b599cd86a3bd7f2 100644

--- a/third_party/WebKit/Source/core/style/ShapeValue.h

+++ b/third_party/WebKit/Source/core/style/ShapeValue.h

@@ -85,7 +85,7 @@ class ShapeValue final : public GarbageCollectedFinalized<ShapeValue> {

private:

ShapeValue(PassRefPtr<BasicShape> shape, CSSBoxType cssBox)

- : m_type(Shape), m_shape(shape), m_cssBox(cssBox) {}

+ : m_type(Shape), m_shape(std::move(shape)), m_cssBox(cssBox) {}

ShapeValue(ShapeValueType type) : m_type(type), m_cssBox(BoxMissing) {}

ShapeValue(StyleImage* image)

: m_type(Image), m_image(image), m_cssBox(ContentBox) {}