third_party/WebKit/Source/core/layout/svg/LayoutSVGResourcePaintServer.cpp - Issue 2761693002: Wrapped PassRefPtrs in move where passed to RefPtr constructor.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/svg/LayoutSVGResourcePaintServer.cpp

Issue 2761693002: Wrapped PassRefPtrs in move where passed to RefPtr constructor. (Closed)

Patch Set: Added move wraps for multiple instances in 1 line. Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/layout/ng/ng_layout_result.cc ('k') | third_party/WebKit/Source/core/loader/FormSubmission.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/svg/LayoutSVGResourcePaintServer.cpp

diff --git a/third_party/WebKit/Source/core/layout/svg/LayoutSVGResourcePaintServer.cpp b/third_party/WebKit/Source/core/layout/svg/LayoutSVGResourcePaintServer.cpp

index 8d4b1770bd0906d7d55fa9d58625c16ff17bf188..7f99b545ff72f018f08a86b2f596906fd9454bd7 100644

--- a/third_party/WebKit/Source/core/layout/svg/LayoutSVGResourcePaintServer.cpp

+++ b/third_party/WebKit/Source/core/layout/svg/LayoutSVGResourcePaintServer.cpp

@@ -36,11 +36,15 @@ SVGPaintServer::SVGPaintServer(Color color) : m_color(color) {}

SVGPaintServer::SVGPaintServer(PassRefPtr<Gradient> gradient,

const AffineTransform& transform)

- : m_gradient(gradient), m_transform(transform), m_color(Color::black) {}

+ : m_gradient(std::move(gradient)),

+ m_transform(transform),

+ m_color(Color::black) {}

SVGPaintServer::SVGPaintServer(PassRefPtr<Pattern> pattern,

const AffineTransform& transform)

- : m_pattern(pattern), m_transform(transform), m_color(Color::black) {}

+ : m_pattern(std::move(pattern)),

+ m_transform(transform),

+ m_color(Color::black) {}

void SVGPaintServer::applyToPaintFlags(PaintFlags& flags, float alpha) {

SkColor baseColor = m_gradient || m_pattern ? SK_ColorBLACK : m_color.rgb();