[dart:io][windows] Use WriteFile instead of _write

[dart:io][windows] Use WriteFile instead of _write

This CL changes File::Write on Windows to call directly to WriteFile()
instead of using _write(). This avoids a number of complexities:
1. Don't need to bother with text vs. binary mode.
2. Don't need to check both errno and GetLastError if _write() fails.
3. Don't need to convert to a wchar_t* for console output since we've
   already set the code page to UTF8.

fixes #29101

R=fschneider@google.com

Committed: https://github.com/dart-lang/sdk/commit/141b6351baacaedf23e740b5b7354970f2ac0979

[zra, 2017-03-29 18:04:59]

zra@google.com changed reviewers:
+ fschneider@google.com

[Florian Schneider, 2017-03-29 18:12:11]

Lgtm

https://codereview.chromium.org/2761673002/diff/20001/runtime/bin/file_win.cc
File runtime/bin/file_win.cc (right):

https://codereview.chromium.org/2761673002/diff/20001/runtime/bin/file_win.cc...
runtime/bin/file_win.cc:140: } else {
No need for else after the return.

[Florian Schneider, 2017-03-29 18:12:12]

Lgtm

[zra, 2017-03-29 19:36:36]

Description was changed from

==========
[dart:io][windows] Use WriteFile instead of _write

This CL changes File::Write on Windows to call directly to WriteFile()
instead of using _write(). This avoids a number of complexities:
1. Don't need to bother with text vs. binary mode.
2. Don't need to check both errno and GetLastError if _write() fails.
3. Don't need to convert to a wchar_t* for console output since we've
   already set the code page to UTF8.
==========

to

==========
[dart:io][windows] Use WriteFile instead of _write

This CL changes File::Write on Windows to call directly to WriteFile()
instead of using _write(). This avoids a number of complexities:
1. Don't need to bother with text vs. binary mode.
2. Don't need to check both errno and GetLastError if _write() fails.
3. Don't need to convert to a wchar_t* for console output since we've
   already set the code page to UTF8.

fixes #29101
==========

[zra, 2017-03-29 20:19:31]

Description was changed from

==========
[dart:io][windows] Use WriteFile instead of _write

This CL changes File::Write on Windows to call directly to WriteFile()
instead of using _write(). This avoids a number of complexities:
1. Don't need to bother with text vs. binary mode.
2. Don't need to check both errno and GetLastError if _write() fails.
3. Don't need to convert to a wchar_t* for console output since we've
   already set the code page to UTF8.

fixes #29101
==========

to

==========
[dart:io][windows] Use WriteFile instead of _write

This CL changes File::Write on Windows to call directly to WriteFile()
instead of using _write(). This avoids a number of complexities:
1. Don't need to bother with text vs. binary mode.
2. Don't need to check both errno and GetLastError if _write() fails.
3. Don't need to convert to a wchar_t* for console output since we've
   already set the code page to UTF8.

fixes #29101

R=fschneider@google.com

Committed:
https://github.com/dart-lang/sdk/commit/141b6351baacaedf23e740b5b7354970f2ac0979
==========

[zra, 2017-03-29 20:19:33]

Committed patchset #4 (id:60001) manually as
141b6351baacaedf23e740b5b7354970f2ac0979 (presubmit successful).

[zra, 2017-03-29 20:20:02]

https://codereview.chromium.org/2761673002/diff/20001/runtime/bin/file_win.cc
File runtime/bin/file_win.cc (right):

https://codereview.chromium.org/2761673002/diff/20001/runtime/bin/file_win.cc...
runtime/bin/file_win.cc:140: } else {
On 2017/03/29 18:12:11, Florian Schneider wrote:
> No need for else after the return.

Done.