Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(406)

Issue 2761633002: Infer fields/getters/setters types according to the new top-level inference rules. (Closed)

Created:
3 years, 9 months ago by scheglov
Modified:
3 years, 9 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Infer fields/getters/setters types according to the new top-level inference rules. R=brianwilkerson@google.com BUG= https://github.com/dart-lang/sdk/issues/28219 Committed: https://github.com/dart-lang/sdk/commit/a9dfc31525d5ef460669c3763f113407dbe0ca50

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+690 lines, -834 lines) Patch
M pkg/analyzer/lib/src/task/strong_mode.dart View 11 chunks +174 lines, -126 lines 0 comments Download
M pkg/analyzer/test/generated/strong_mode_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/test/src/summary/element_text.dart View 9 chunks +40 lines, -33 lines 0 comments Download
M pkg/analyzer/test/src/summary/resynthesize_common.dart View 30 chunks +64 lines, -64 lines 0 comments Download
M pkg/analyzer/test/src/summary/top_level_inference_test.dart View 8 chunks +408 lines, -69 lines 0 comments Download
M pkg/analyzer/test/src/task/strong/inferred_type_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/analyzer/test/src/task/strong_mode_test.dart View 2 chunks +0 lines, -539 lines 0 comments Download
M pkg/dev_compiler/test/not_yet_strong_tests.dart View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
scheglov
3 years, 9 months ago (2017-03-19 01:55:10 UTC) #1
Brian Wilkerson
lgtm
3 years, 9 months ago (2017-03-19 16:59:47 UTC) #2
scheglov
3 years, 9 months ago (2017-03-19 17:09:51 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
a9dfc31525d5ef460669c3763f113407dbe0ca50 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698