Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Issue 276163002: Revert of Avoids releasing capture in EndMoveLoop if capture was switched to another window while .. (Closed)

Created:
6 years, 7 months ago by mdempsky
Modified:
6 years, 7 months ago
CC:
chromium-reviews, tfarina, ben+views_chromium.org, tdanderson+views_chromium.org, mdempsky
Visibility:
Public.

Description

Revert of Avoids releasing capture in EndMoveLoop if capture was switched to another window while dragging (https://codereview.chromium.org/265843004/) Reason for revert: Appears to be responsible for ash_unittests failing on Linux ChromiumOS Tests(1): http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%281%29/builds/43114 Original issue's description: > Avoids releasing capture in EndMoveLoop if capture was switched to another window while dragging. > This variant relies on checking if a drag input window still has capture before releasing the grab. > A better alternative is in CL https://codereview.chromium.org/262893002/. > > BUG=363503 > TEST=Follow the exact steps in the bug description. > TEST=interactive_ui_tests --gtest_filter=*TabDragging* > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=269593 TBR=sadrul@chromium.org,varkha@chromium.org NOTREECHECKS=true NOTRY=true BUG=363503 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=269629

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -15 lines) Patch
M ui/views/widget/desktop_aura/x11_whole_screen_move_loop.h View 1 chunk +0 lines, -3 lines 0 comments Download
M ui/views/widget/desktop_aura/x11_whole_screen_move_loop.cc View 4 chunks +2 lines, -12 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
mdempsky
Created Revert of Avoids releasing capture in EndMoveLoop if capture was switched to another window ...
6 years, 7 months ago (2014-05-10 20:29:07 UTC) #1
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-10 20:29:24 UTC) #2
mdempsky
The CQ bit was checked by mdempsky@chromium.org
6 years, 7 months ago (2014-05-10 20:30:24 UTC) #3
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-10 20:30:42 UTC) #4
Alpha Left Google
The CQ bit was checked by hclam@chromium.org
6 years, 7 months ago (2014-05-10 20:31:28 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-10 20:31:58 UTC) #6
Alpha Left Google
lgtm lgtm
6 years, 7 months ago (2014-05-10 20:33:58 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mdempsky@chromium.org/276163002/1
6 years, 7 months ago (2014-05-10 20:34:25 UTC) #8
commit-bot: I haz the power
6 years, 7 months ago (2014-05-10 20:36:02 UTC) #9
Message was sent while issue was closed.
Change committed as 269629

Powered by Google App Engine
This is Rietveld 408576698