Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1199)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2761593002: Reapply "DWARF and unwind support for AOT assembly output." (Closed)

Created:
3 years, 9 months ago by rmacnak
Modified:
3 years, 9 months ago
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Reapply "DWARF and unwind support for AOT assembly output." This reverts commit 8fcdbb4a7f4bc484fdef49422665e74d16770cb6. R=vegorov@google.com Committed: https://github.com/dart-lang/sdk/commit/b09552cd629f8006f86757649fbbca625da69259

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1255 lines, -129 lines) Patch
M runtime/vm/assembler_arm.cc View 1 chunk +3 lines, -1 line 0 comments Download
M runtime/vm/clustered_snapshot.cc View 2 chunks +11 lines, -6 lines 0 comments Download
M runtime/vm/dart.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M runtime/vm/dart_api_impl.cc View 2 chunks +6 lines, -0 lines 0 comments Download
M runtime/vm/datastream.h View 2 chunks +23 lines, -22 lines 0 comments Download
A runtime/vm/dwarf.h View 1 chunk +207 lines, -0 lines 0 comments Download
A runtime/vm/dwarf.cc View 1 chunk +643 lines, -0 lines 0 comments Download
M runtime/vm/flag_list.h View 1 chunk +3 lines, -0 lines 0 comments Download
M runtime/vm/flags.cc View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/vm/hash_map.h View 2 chunks +7 lines, -0 lines 0 comments Download
M runtime/vm/native_symbol.h View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/vm/native_symbol_android.cc View 1 chunk +13 lines, -0 lines 0 comments Download
M runtime/vm/native_symbol_fuchsia.cc View 1 chunk +14 lines, -0 lines 0 comments Download
M runtime/vm/native_symbol_linux.cc View 1 chunk +13 lines, -0 lines 0 comments Download
M runtime/vm/native_symbol_macos.cc View 1 chunk +13 lines, -0 lines 0 comments Download
M runtime/vm/native_symbol_win.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M runtime/vm/object.h View 1 chunk +3 lines, -5 lines 0 comments Download
M runtime/vm/object.cc View 8 chunks +95 lines, -17 lines 0 comments Download
M runtime/vm/object_service.cc View 1 chunk +1 line, -2 lines 0 comments Download
M runtime/vm/precompiler.cc View 18 chunks +18 lines, -18 lines 0 comments Download
M runtime/vm/snapshot.h View 4 chunks +7 lines, -4 lines 0 comments Download
M runtime/vm/snapshot.cc View 10 chunks +161 lines, -54 lines 0 comments Download
M runtime/vm/vm_sources.gypi View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
rmacnak
Pending CL to update vm-noopt-simarm64-mac.
3 years, 9 months ago (2017-03-17 23:59:51 UTC) #2
Vyacheslav Egorov (Google)
lgtm
3 years, 9 months ago (2017-03-20 17:10:25 UTC) #3
rmacnak
3 years, 9 months ago (2017-03-20 20:02:48 UTC) #5
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
b09552cd629f8006f86757649fbbca625da69259 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698