chrome/android/java/src/org/chromium/chrome/browser/preferences/autofill/AutofillEditorBase.java - Issue 2761583002: Make FadingEdgeScrollView more generic

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/preferences/autofill/AutofillEditorBase.java

Issue 2761583002: Make FadingEdgeScrollView more generic (Closed)

Patch Set: Comments, added hard edge for payments Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/payments/ui/PaymentRequestUI.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/widget/FadingEdgeScrollView.java » ('j') | chrome/android/java/src/org/chromium/chrome/browser/widget/FadingEdgeScrollView.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/preferences/autofill/AutofillEditorBase.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/preferences/autofill/AutofillEditorBase.java b/chrome/android/java/src/org/chromium/chrome/browser/preferences/autofill/AutofillEditorBase.java

index 8017eb5fdc469356b712e98cd45748f400fdb66d..d11682cc156183ae1368abd29ca27afcf5c02500 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/preferences/autofill/AutofillEditorBase.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/preferences/autofill/AutofillEditorBase.java

@@ -27,8 +27,8 @@ import android.widget.Spinner;

import org.chromium.chrome.R;

import org.chromium.chrome.browser.payments.ui.EditorView;

-import org.chromium.chrome.browser.payments.ui.FadingEdgeScrollView;

import org.chromium.chrome.browser.widget.DualControlLayout;

+import org.chromium.chrome.browser.widget.FadingEdgeScrollView;

/** Base class for Autofill editors (e.g. credit cards and profiles). */

public abstract class AutofillEditorBase

@@ -67,7 +67,8 @@ public abstract class AutofillEditorBase

// Hide the top shadow on the ScrollView because the toolbar draws one.

FadingEdgeScrollView scrollView = (FadingEdgeScrollView) inflater.inflate(

R.layout.autofill_editor_base, container, false);

- scrollView.setShadowVisibility(false, true);

+ scrollView.setEdgeVisibility(

+ FadingEdgeScrollView.DRAW_NO_EDGE, FadingEdgeScrollView.DRAW_FADING_EDGE);

// Inflate the editor and buttons into the "content" LinearLayout.

LinearLayout contentLayout = (LinearLayout) scrollView.findViewById(R.id.content);