chrome/android/java/src/org/chromium/chrome/browser/payments/ui/EditorView.java - Issue 2761583002: Make FadingEdgeScrollView more generic

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/payments/ui/EditorView.java

Issue 2761583002: Make FadingEdgeScrollView more generic (Closed)

Patch Set: Comments, added hard edge for payments Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/res/values/dimens.xml ('k') | chrome/android/java/src/org/chromium/chrome/browser/payments/ui/FadingEdgeScrollView.java » ('j') | chrome/android/java/src/org/chromium/chrome/browser/widget/FadingEdgeScrollView.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/payments/ui/EditorView.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/payments/ui/EditorView.java b/chrome/android/java/src/org/chromium/chrome/browser/payments/ui/EditorView.java

index da90122fc5af289965681be875edb45f3f87459d..4b079deeff203ba9cbdc47a25ea9c48798d7a1f1 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/payments/ui/EditorView.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/payments/ui/EditorView.java

@@ -44,6 +44,7 @@ import org.chromium.chrome.browser.payments.ui.PaymentRequestUI.PaymentRequestOb

import org.chromium.chrome.browser.preferences.autofill.CreditCardNumberFormattingTextWatcher;

import org.chromium.chrome.browser.widget.AlwaysDismissedDialog;

import org.chromium.chrome.browser.widget.DualControlLayout;

+import org.chromium.chrome.browser.widget.FadingEdgeScrollView;

import org.chromium.chrome.browser.widget.FadingShadow;

import org.chromium.chrome.browser.widget.FadingShadowView;

import org.chromium.ui.UiUtils;

@@ -197,7 +198,8 @@ public class EditorView extends AlwaysDismissedDialog implements OnClickListener

// The top shadow is handled by the toolbar, so hide the one used in the field editor.

FadingEdgeScrollView scrollView =

(FadingEdgeScrollView) mLayout.findViewById(R.id.scroll_view);

- scrollView.setShadowVisibility(false, true);

+ scrollView.setEdgeVisibility(

+ FadingEdgeScrollView.DRAW_NO_EDGE, FadingEdgeScrollView.DRAW_FADING_EDGE);

}

/**