Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2049)

Unified Diff: third_party/WebKit/Source/core/layout/compositing/GraphicsLayerUpdater.cpp

Issue 2761413002: Fix position of floating layer whose containing block is also floating (Closed)
Patch Set: TODO in GraphicsLayerUpdater Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/paint/PaintLayer.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/layout/compositing/GraphicsLayerUpdater.cpp
diff --git a/third_party/WebKit/Source/core/layout/compositing/GraphicsLayerUpdater.cpp b/third_party/WebKit/Source/core/layout/compositing/GraphicsLayerUpdater.cpp
index ebe6007f2e3d1407cfdf6c5b929741991dc77915..66172b83c5ce8126e3a17fc1d5428ed415440105 100644
--- a/third_party/WebKit/Source/core/layout/compositing/GraphicsLayerUpdater.cpp
+++ b/third_party/WebKit/Source/core/layout/compositing/GraphicsLayerUpdater.cpp
@@ -57,6 +57,10 @@ class GraphicsLayerUpdater::UpdateContext {
if (layer.stackingNode()->isStacked())
return m_compositingStackingContext;
+ // TODO(wangxianzhu, chrishtr): This is incorrect if m_compositingAncestor
+ // is inline and there is any non-layer floating object between layer and
+ // m_compositingAncestor. Should use the logic in PaintLayer::
+ // containingLayer().
if (layer.layoutObject().isFloatingWithNonContainingBlockParent())
return layer.enclosingLayerWithCompositedLayerMapping(ExcludeSelf);
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/paint/PaintLayer.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698