Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(428)

Unified Diff: services/ui/ws/window_tree.cc

Issue 2761383002: Fix the error message in ui::ws::WindowTree::StackAbove method (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: services/ui/ws/window_tree.cc
diff --git a/services/ui/ws/window_tree.cc b/services/ui/ws/window_tree.cc
index 2e2f73bfdd471cbb3a3beebc78c98f00caf11dfb..4db91d1bf04e37db883d83070d097fbf2db368c7 100644
--- a/services/ui/ws/window_tree.cc
+++ b/services/ui/ws/window_tree.cc
@@ -1662,20 +1662,20 @@ void WindowTree::DeactivateWindow(Id window_id) {
void WindowTree::StackAbove(uint32_t change_id, Id above_id, Id below_id) {
ServerWindow* above = GetWindowByClientId(ClientWindowId(above_id));
if (!above) {
- DVLOG(1) << "StackAtTop failed (invalid above id)";
+ DVLOG(1) << "StackAbove failed (invalid above id)";
client()->OnChangeCompleted(change_id, false);
return;
}
ServerWindow* below = GetWindowByClientId(ClientWindowId(below_id));
if (!below) {
- DVLOG(1) << "StackAtTop failed (invalid below id)";
+ DVLOG(1) << "StackAbove failed (invalid below id)";
client()->OnChangeCompleted(change_id, false);
return;
}
if (!access_policy_->CanStackAbove(above, below)) {
- DVLOG(1) << "StackAtTop failed (access denied)";
+ DVLOG(1) << "StackAbove failed (access denied)";
client()->OnChangeCompleted(change_id, false);
return;
}
@@ -1683,24 +1683,24 @@ void WindowTree::StackAbove(uint32_t change_id, Id above_id, Id below_id) {
ServerWindow* parent = above->parent();
ServerWindow* below_parent = below->parent();
if (!parent) {
- DVLOG(1) << "StackAtTop failed (above unparented)";
+ DVLOG(1) << "StackAbove failed (above unparented)";
client()->OnChangeCompleted(change_id, false);
return;
}
if (!below_parent) {
- DVLOG(1) << "StackAtTop failed (below unparented)";
+ DVLOG(1) << "StackAbove failed (below unparented)";
client()->OnChangeCompleted(change_id, false);
return;
}
if (parent != below_parent) {
- DVLOG(1) << "StackAtTop failed (windows have different parents)";
+ DVLOG(1) << "StackAbove failed (windows have different parents)";
client()->OnChangeCompleted(change_id, false);
return;
}
WindowManagerDisplayRoot* display_root = GetWindowManagerDisplayRoot(above);
if (!display_root) {
- DVLOG(1) << "StackAtTop (no display root)";
+ DVLOG(1) << "StackAbove (no display root)";
client()->OnChangeCompleted(change_id, false);
return;
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698