Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(255)

Unified Diff: ios/clean/chrome/browser/ui/toolbar/toolbar_coordinator.mm

Issue 2761343002: [ios] Adds LocationBarCoordinator. (Closed)
Patch Set: Rebased. Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/clean/chrome/browser/ui/toolbar/toolbar_coordinator.mm
diff --git a/ios/clean/chrome/browser/ui/toolbar/toolbar_coordinator.mm b/ios/clean/chrome/browser/ui/toolbar/toolbar_coordinator.mm
index 6ba3e81886780cf22f8800a1a8203dd9019959e7..b394cae50cf0ab392d7392feafa780b9c9eeeda1 100644
--- a/ios/clean/chrome/browser/ui/toolbar/toolbar_coordinator.mm
+++ b/ios/clean/chrome/browser/ui/toolbar/toolbar_coordinator.mm
@@ -5,6 +5,7 @@
#import "ios/clean/chrome/browser/ui/toolbar/toolbar_coordinator.h"
#import "ios/clean/chrome/browser/ui/commands/tools_menu_commands.h"
+#import "ios/clean/chrome/browser/ui/omnibox/location_bar_coordinator.h"
#import "ios/clean/chrome/browser/ui/toolbar/toolbar_mediator.h"
#import "ios/clean/chrome/browser/ui/toolbar/toolbar_view_controller.h"
#import "ios/clean/chrome/browser/ui/tools/tools_coordinator.h"
@@ -60,6 +61,13 @@
self.viewController.dispatcher = static_cast<id>(self.browser->dispatcher());
self.mediator.consumer = self.viewController;
+ LocationBarCoordinator* locationBarCoordinator =
+ [[LocationBarCoordinator alloc] init];
+ [self addChildCoordinator:locationBarCoordinator];
+ [locationBarCoordinator start];
+ self.viewController.locationBarViewController =
+ locationBarCoordinator.viewController;
marq (ping after 24h) 2017/04/05 09:07:19 Should this part be in -childCoordinatorDidStart?
rohitrao (ping after 24h) 2017/04/05 14:37:05 Moved. I don't think we ever decided on the patte
marq (ping after 24h) 2017/04/05 14:59:10 Yes, we should do a cleanup pass.
+
[self.context.baseViewController presentViewController:self.viewController
animated:self.context.animated
completion:nil];

Powered by Google App Engine
This is Rietveld 408576698