[ios] Adds LocationBarCoordinator.

ios/clean/chrome/browser/ui/omnibox/location_bar_view_controller.mm

+// Copyright 2017 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#import "ios/clean/chrome/browser/ui/omnibox/location_bar_view_controller.h"
+
+#import "ios/chrome/browser/ui/omnibox/omnibox_text_field_ios.h"
+
+#if !defined(__has_feature) || !__has_feature(objc_arc)
+#error "This file requires ARC support."
+#endif
+
+@interface LocationBarViewController ()
+@property(nonatomic, readwrite, strong) OmniboxTextFieldIOS* omnibox;
+@end
+
+@implementation LocationBarViewController {

[marq (ping after 24h), 2017/04/05 09:07:19]

Spurious {}

[rohitrao (ping after 24h), 2017/04/05 14:37:05]

I was expecting to need them for something =)

+}
+
+@synthesize omnibox = _omnibox;
+
+- (instancetype)init {
+  if ((self = [super init])) {
+    UIColor* textColor = [UIColor blackColor];
+    UIColor* tintColor = nil;
+    self.omnibox =

[marq (ping after 24h), 2017/04/05 09:07:19]

Don't assign to properties in the init; use _omnibox instead.

[rohitrao (ping after 24h), 2017/04/05 14:37:05]

Done.  We are not consistent about this in ios/clean, but I agree that we
shouldn't use properties in init.

[marq (ping after 24h), 2017/04/05 14:59:10]

We should be consistent with this. I'll do a cleanup pass.

+        [[OmniboxTextFieldIOS alloc] initWithFrame:CGRectZero
+                                              font:[UIFont systemFontOfSize:14]
+                                         textColor:textColor
+                                         tintColor:tintColor];
+  }
+  return self;
+}
+
+- (void)loadView {
+  self.view = [[UIView alloc] initWithFrame:CGRectZero];
+  self.omnibox.translatesAutoresizingMaskIntoConstraints = YES;

[marq (ping after 24h), 2017/04/05 09:07:19]

YES is the default, so no need for this (unless it's not the default for the
superclass, in which case a comment would be good).

[rohitrao (ping after 24h), 2017/04/05 14:37:05]

Done.

+  self.omnibox.autoresizingMask =
+      UIViewAutoresizingFlexibleWidth | UIViewAutoresizingFlexibleHeight;
+  self.omnibox.frame = self.view.bounds;
+  [self.view addSubview:self.omnibox];

[marq (ping after 24h), 2017/04/05 09:07:19]

Why do this in -loadView and not -viewDidLoad ?

[rohitrao (ping after 24h), 2017/04/05 14:37:05]

Moved.

+}
+
+@end