net/cert/x509_certificate_nss.cc - Issue 2761333002: Add a DevTools warning for a missing subjectAltName

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/cert/x509_certificate_nss.cc

Issue 2761333002: Add a DevTools warning for a missing subjectAltName (Closed)

Patch Set: iOS & NSS fix Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/cert/x509_certificate_nss.cc

diff --git a/net/cert/x509_certificate_nss.cc b/net/cert/x509_certificate_nss.cc

index 822102fe153c3c0b89402e87cbc36809bae2522b..c418b9dcb53aa7c866f8a6dbf5301af36c7e5f91 100644

--- a/net/cert/x509_certificate_nss.cc

+++ b/net/cert/x509_certificate_nss.cc

@@ -91,7 +91,7 @@ std::string X509Certificate::GetDefaultNickname(CertType type) const {

void X509Certificate::GetSubjectAltName(

std::vector<std::string>* dns_names,

std::vector<std::string>* ip_addrs) const {

- x509_util::GetSubjectAltName(cert_handle_, dns_names, ip_addrs);

+ return x509_util::GetSubjectAltName(cert_handle_, dns_names, ip_addrs);

}

bool X509Certificate::IsIssuedByEncoded(