Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(192)

Unified Diff: net/cert/x509_util_nss.h

Issue 2761333002: Add a DevTools warning for a missing subjectAltName (Closed)
Patch Set: Feedback & fixes Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/cert/x509_certificate_win.cc ('k') | net/cert/x509_util_nss.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/cert/x509_util_nss.h
diff --git a/net/cert/x509_util_nss.h b/net/cert/x509_util_nss.h
index d0839c9cbf6028bf63d770efa3de81cd2647f875..b11a91ffcb57c5c9b73b620779db480781b59f16 100644
--- a/net/cert/x509_util_nss.h
+++ b/net/cert/x509_util_nss.h
@@ -39,12 +39,12 @@ void ParseDate(const SECItem* der_date, base::Time* result);
// Parses the serial number from |certificate|.
std::string ParseSerialNumber(const CERTCertificate* certificate);
-// Gets the dNSName and iPAddress name types from the subjectAltName
-// extension of |cert_handle|, storing them in |dns_names| and
-// |ip_addrs|, respectively.
-// If no subjectAltName is present, or no names of that type are
-// present, the relevant vectors are cleared.
-void GetSubjectAltName(CERTCertificate* cert_handle,
+// Gets the dNSName and iPAddress name fields from the subjectAltName
+// extension of |cert_handle|.
+// If |dns_names| is non-null, each dNSName will be stored in |*dns_names|.
+// If |ip_addrs| is non-null, each iPAddress will be stored in |*ip_addrs|.
+// Returns true if any dNSName or iPAddress was present.
+bool GetSubjectAltName(CERTCertificate* cert_handle,
std::vector<std::string>* dns_names,
std::vector<std::string>* ip_addrs);
« no previous file with comments | « net/cert/x509_certificate_win.cc ('k') | net/cert/x509_util_nss.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698