Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(427)

Unified Diff: components/security_state/content/content_utils.cc

Issue 2761333002: Add a DevTools warning for a missing subjectAltName (Closed)
Patch Set: Feedback & fixes Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/security_state/content/content_utils.cc
diff --git a/components/security_state/content/content_utils.cc b/components/security_state/content/content_utils.cc
index ae007c335a78b8fc897250b621a3f22da0937e43..8fd95ea24825c849373a4394ec518338b0a8535d 100644
--- a/components/security_state/content/content_utils.cc
+++ b/components/security_state/content/content_utils.cc
@@ -226,6 +226,14 @@ blink::WebSecurityStyle GetSecurityStyle(
!!security_info.certificate));
}
+ if (security_info.cert_missing_subject_alt_name) {
+ security_style_explanations->broken_explanations.push_back(
+ content::SecurityStyleExplanation(
+ l10n_util::GetStringUTF8(IDS_SUBJECT_ALT_NAME_MISSING),
+ l10n_util::GetStringUTF8(IDS_SUBJECT_ALT_NAME_MISSING_DESCRIPTION),
+ !!security_info.certificate));
+ }
+
// Record the presence of mixed content (HTTP subresources on an HTTPS
// page).
security_style_explanations->ran_mixed_content =
« no previous file with comments | « components/security_state/content/BUILD.gn ('k') | components/security_state/content/content_utils_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698