Add a DevTools warning for a missing subjectAltName

components/security_state/content/content_utils_unittest.cc

Index: components/security_state/content/content_utils_unittest.cc
diff --git a/components/security_state/content/content_utils_unittest.cc b/components/security_state/content/content_utils_unittest.cc
index 41395a8e3ba9cc5f04c77d572b2c0f50bd24eab9..b04fe96f220f503f169acc04fb501a21f6d5b3fb 100644
--- a/components/security_state/content/content_utils_unittest.cc
+++ b/components/security_state/content/content_utils_unittest.cc
@@ -13,6 +13,8 @@
 #include "net/cert/cert_status_flags.h"
 #include "net/ssl/ssl_cipher_suite_names.h"
 #include "net/ssl/ssl_connection_status_flags.h"
+#include "net/test/cert_test_util.h"
+#include "net/test/test_data_directory.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 namespace {
@@ -232,4 +234,25 @@ TEST(SecurityStateContentUtilsTest, HTTPWarning) {
   EXPECT_EQ(1u, explanations.unauthenticated_explanations.size());
 }
 
+// Test that an explanation is provided if a certificate is missing a

[estark, 2017/03/21 23:33:03]

nit: Tests

+// subjectAltName extension containing a domain name or IP address.
+TEST(SecurityStateContentUtilsTest, SubjectAltNameWarning) {
+  security_state::SecurityInfo security_info;
+  security_info.certificate = net::ImportCertFromFile(
+      net::GetTestCertsDirectory(), "salesforce_com_test.pem");
+  ASSERT_TRUE(security_info.certificate);
+
+  content::SecurityStyleExplanations explanations;
+  security_info.cert_missing_subject_alt_name = true;
+  GetSecurityStyle(security_info, &explanations);
+  // Verify that an explanation was shown for a missing subjectAltName.
+  EXPECT_EQ(1u, explanations.unauthenticated_explanations.size());
+
+  explanations.unauthenticated_explanations.clear();
+  security_info.cert_missing_subject_alt_name = false;
+  GetSecurityStyle(security_info, &explanations);
+  // Verify that no explanation is shown if the subjectAltName is present.
+  EXPECT_EQ(0u, explanations.unauthenticated_explanations.size());
+}
+
 }  // namespace