Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10253)

Unified Diff: components/security_state/core/security_state.h

Issue 2761333002: Add a DevTools warning for a missing subjectAltName (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/security_state/core/security_state.h
diff --git a/components/security_state/core/security_state.h b/components/security_state/core/security_state.h
index 7de0fa7437b5d1961a67425d30069ce050207ce7..6c7194cfcbc102ca6d3966942ab1809c8922afdd 100644
--- a/components/security_state/core/security_state.h
+++ b/components/security_state/core/security_state.h
@@ -142,6 +142,10 @@ struct SecurityInfo {
// True if the page displayed credit card field on an HTTP page.
bool displayed_credit_card_field_on_http;
+
+ // True if a subjectAlternativeName extension is missing from the
+ // server's certificate.
elawrence 2017/03/21 16:22:54 Maybe "True if the server's certificate does not c
+ bool san_is_missing;
elawrence 2017/03/21 16:22:54 similarly, maybe "cert_lacks_SAN"?
Ryan Sleevi 2017/03/21 16:41:41 Was trying to match the naming style for sha1_in_c
elawrence 2017/03/21 16:49:04 SGTM
};
// Contains the security state relevant to computing the SecurityInfo

Powered by Google App Engine
This is Rietveld 408576698