Add a DevTools warning for a missing subjectAltName

net/cert/x509_util_nss.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef NET_CERT_X509_UTIL_NSS_H_
 #define NET_CERT_X509_UTIL_NSS_H_
 
 #include <stddef.h>
 
 #include <string>
@@ skipping 21 matching lines @@
 // |principal|.
 void ParsePrincipal(CERTName* name,
                     CertPrincipal* principal);
 
 // Parses the date from |der_date| and outputs the result in |result|.
 void ParseDate(const SECItem* der_date, base::Time* result);
 
 // Parses the serial number from |certificate|.
 std::string ParseSerialNumber(const CERTCertificate* certificate);
 
-// Gets the dNSName and iPAddress name types from the subjectAltName
-// extension of |cert_handle|, storing them in |dns_names| and
-// |ip_addrs|, respectively.
-// If no subjectAltName is present, or no names of that type are
-// present, the relevant vectors are cleared.
-void GetSubjectAltName(CERTCertificate* cert_handle,
+// Gets the dNSName and iPAddress name fields from the subjectAltName
+// extension of |cert_handle|.
+// If |dns_names| is non-NULL, each dNSName will be stored in |*dns_names|.

[eroman, 2017/03/21 21:09:54]

(this is the style comment I was suggesting for the common header).

+// If |ip_addrs| is non-NULL, each iPAddress will be stored in |*ip_addrs|.
+// Returns true if any dNSName or iPAddress was present.
+bool GetSubjectAltName(CERTCertificate* cert_handle,
                        std::vector<std::string>* dns_names,
                        std::vector<std::string>* ip_addrs);
 
 // Stores the values of all rfc822Name subjectAltNames from |cert_handle|
 // into |names|. If no names are present, clears |names|.
 // WARNING: This method does not validate that the rfc822Name is
 // properly encoded; it MAY contain embedded NULs or other illegal
 // characters; care should be taken to validate the well-formedness
 // before using.
 NET_EXPORT void GetRFC822SubjectAltNames(CERTCertificate* cert_handle,
@@ skipping 67 matching lines @@
 // TODO(gspencer): Internationalize this: it's wrong to hard-code English.
 std::string GetUniqueNicknameForSlot(const std::string& nickname,
                                      const SECItem* subject,
                                      PK11SlotInfo* slot);
 
 } // namespace x509_util
 
 } // namespace net
 
 #endif  // NET_CERT_X509_UTIL_NSS_H_