Add a DevTools warning for a missing subjectAltName

components/security_state/content/content_utils.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/security_state/content/content_utils.h"
 
 #include <string>
 #include <vector>
 
 #include "base/memory/ptr_util.h"
@@ skipping 208 matching lines @@
   }
 
   if (security_info.sha1_in_chain) {
     security_style_explanations->unauthenticated_explanations.push_back(
         content::SecurityStyleExplanation(
             l10n_util::GetStringUTF8(IDS_SHA1),
             l10n_util::GetStringUTF8(IDS_SHA1_DESCRIPTION),
             !!security_info.certificate));
   }
 
+  if (security_info.cert_missing_subject_alt_name) {
+    security_style_explanations->unauthenticated_explanations.push_back(

[estark, 2017/03/21 23:33:03]

I think this probably should be |broken_explanations|, at least in the case
where IsCertStatusError is true.

Apologies that these fields are poorly named/documented, and not particularly
well-differentiated in the UI right now, but |unauthenticated_explanations| is
supposed to be "This is why your page got downgraded to the (i) icon" and
|broken_explanations| is supposed to be "This is why your page has the red
Dangerous triangle."

(filed crbug.com/703882 to clean up the field names/comments)

[Ryan Sleevi, 2017/03/22 00:10:47]

I left it as broken for all cases, does that work? If only because it's the
"thing that will break soon" (but we don't presently degrade the lock icon in
the case of enterprise policy)

[estark, 2017/03/22 00:16:21]

Yeah, that's fine by me, thanks.

+        content::SecurityStyleExplanation(
+            l10n_util::GetStringUTF8(IDS_SUBJECT_ALT_NAME_MISSING),
+            l10n_util::GetStringUTF8(IDS_SUBJECT_ALT_NAME_MISSING_DESCRIPTION),
+            !!security_info.certificate));
+  }
+
   // Record the presence of mixed content (HTTP subresources on an HTTPS
   // page).
   security_style_explanations->ran_mixed_content =
       security_info.mixed_content_status ==
           security_state::CONTENT_STATUS_RAN ||
       security_info.mixed_content_status ==
           security_state::CONTENT_STATUS_DISPLAYED_AND_RAN;
   security_style_explanations->displayed_mixed_content =
       security_info.mixed_content_status ==
           security_state::CONTENT_STATUS_DISPLAYED ||
@@ skipping 59 matching lines @@
     security_style_explanations->info_explanations.push_back(
         content::SecurityStyleExplanation(
             "Public-Key Pinning Bypassed",
             "Public-key pinning was bypassed by a local root certificate."));
   }
 
   return security_style;
 }
 
 }  // namespace security_state